Add support for windows-style path (backslashes)#11073
Add support for windows-style path (backslashes)#11073gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
Source filename used in probe definition can have path using backslashes (Windows-style) we normalize those paths before building the definition matcher
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (339.008 µs) : 293, 385
. : milestone, 339,
basic (290.242 µs) : 283, 297
. : milestone, 290,
loop (8.968 ms) : 8962, 8973
. : milestone, 8968,
section candidate
noprobe (338.179 µs) : 291, 385
. : milestone, 338,
basic (293.416 µs) : 287, 300
. : milestone, 293,
loop (8.983 ms) : 8978, 8988
. : milestone, 8983,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~2578e2c1f7, baseline=1.62.0-SNAPSHOT~b266e2d0c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055537
Total [baseline] (8.819 s) : 0, 8818748
Agent [candidate] (1.064 s) : 0, 1063742
Total [candidate] (8.857 s) : 0, 8857143
section iast
Agent [baseline] (1.224 s) : 0, 1224398
Total [baseline] (9.545 s) : 0, 9545323
Agent [candidate] (1.234 s) : 0, 1234144
Total [candidate] (9.556 s) : 0, 9555635
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~2578e2c1f7, baseline=1.62.0-SNAPSHOT~b266e2d0c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.245 ms) : 0, 1245
crashtracking [candidate] (1.239 ms) : 0, 1239
BytebuddyAgent [baseline] (632.006 ms) : 0, 632006
BytebuddyAgent [candidate] (637.25 ms) : 0, 637250
AgentMeter [baseline] (29.463 ms) : 0, 29463
AgentMeter [candidate] (29.669 ms) : 0, 29669
GlobalTracer [baseline] (248.637 ms) : 0, 248637
GlobalTracer [candidate] (250.284 ms) : 0, 250284
AppSec [baseline] (32.035 ms) : 0, 32035
AppSec [candidate] (32.081 ms) : 0, 32081
Debugger [baseline] (58.994 ms) : 0, 58994
Debugger [candidate] (59.2 ms) : 0, 59200
Remote Config [baseline] (603.142 µs) : 0, 603
Remote Config [candidate] (618.4 µs) : 0, 618
Telemetry [baseline] (8.061 ms) : 0, 8061
Telemetry [candidate] (8.168 ms) : 0, 8168
Flare Poller [baseline] (8.231 ms) : 0, 8231
Flare Poller [candidate] (8.906 ms) : 0, 8906
section iast
crashtracking [baseline] (1.246 ms) : 0, 1246
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (802.302 ms) : 0, 802302
BytebuddyAgent [candidate] (809.276 ms) : 0, 809276
AgentMeter [baseline] (11.359 ms) : 0, 11359
AgentMeter [candidate] (11.57 ms) : 0, 11570
GlobalTracer [baseline] (238.973 ms) : 0, 238973
GlobalTracer [candidate] (240.597 ms) : 0, 240597
IAST [baseline] (25.696 ms) : 0, 25696
IAST [candidate] (26.01 ms) : 0, 26010
AppSec [baseline] (30.208 ms) : 0, 30208
AppSec [candidate] (33.641 ms) : 0, 33641
Debugger [baseline] (60.781 ms) : 0, 60781
Debugger [candidate] (58.441 ms) : 0, 58441
Remote Config [baseline] (546.45 µs) : 0, 546
Remote Config [candidate] (534.658 µs) : 0, 535
Telemetry [baseline] (13.276 ms) : 0, 13276
Telemetry [candidate] (12.716 ms) : 0, 12716
Flare Poller [baseline] (3.489 ms) : 0, 3489
Flare Poller [candidate] (3.48 ms) : 0, 3480
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~2578e2c1f7, baseline=1.62.0-SNAPSHOT~b266e2d0c2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059666
Total [baseline] (11.058 s) : 0, 11057973
Agent [candidate] (1.059 s) : 0, 1058578
Total [candidate] (11.147 s) : 0, 11147409
section appsec
Agent [baseline] (1.25 s) : 0, 1249772
Total [baseline] (11.165 s) : 0, 11165467
Agent [candidate] (1.259 s) : 0, 1259296
Total [candidate] (11.237 s) : 0, 11236613
section iast
Agent [baseline] (1.228 s) : 0, 1227711
Total [baseline] (11.329 s) : 0, 11328591
Agent [candidate] (1.229 s) : 0, 1229260
Total [candidate] (11.269 s) : 0, 11269371
section profiling
Agent [baseline] (1.194 s) : 0, 1194492
Total [baseline] (11.291 s) : 0, 11290903
Agent [candidate] (1.187 s) : 0, 1187325
Total [candidate] (11.118 s) : 0, 11117598
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~2578e2c1f7, baseline=1.62.0-SNAPSHOT~b266e2d0c2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.234 ms) : 0, 1234
BytebuddyAgent [baseline] (634.5 ms) : 0, 634500
BytebuddyAgent [candidate] (634.199 ms) : 0, 634199
AgentMeter [baseline] (29.4 ms) : 0, 29400
AgentMeter [candidate] (29.51 ms) : 0, 29510
GlobalTracer [baseline] (249.253 ms) : 0, 249253
GlobalTracer [candidate] (249.355 ms) : 0, 249355
AppSec [baseline] (32.014 ms) : 0, 32014
AppSec [candidate] (31.986 ms) : 0, 31986
Debugger [baseline] (60.017 ms) : 0, 60017
Debugger [candidate] (59.948 ms) : 0, 59948
Remote Config [baseline] (607.75 µs) : 0, 608
Remote Config [candidate] (592.732 µs) : 0, 593
Telemetry [baseline] (8.17 ms) : 0, 8170
Telemetry [candidate] (8.105 ms) : 0, 8105
Flare Poller [baseline] (8.227 ms) : 0, 8227
Flare Poller [candidate] (7.374 ms) : 0, 7374
section appsec
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.245 ms) : 0, 1245
BytebuddyAgent [baseline] (662.032 ms) : 0, 662032
BytebuddyAgent [candidate] (667.3 ms) : 0, 667300
AgentMeter [baseline] (12.058 ms) : 0, 12058
AgentMeter [candidate] (12.131 ms) : 0, 12131
GlobalTracer [baseline] (249.011 ms) : 0, 249011
GlobalTracer [candidate] (251.351 ms) : 0, 251351
IAST [baseline] (24.631 ms) : 0, 24631
IAST [candidate] (24.901 ms) : 0, 24901
AppSec [baseline] (185.175 ms) : 0, 185175
AppSec [candidate] (186.223 ms) : 0, 186223
Debugger [baseline] (66.429 ms) : 0, 66429
Debugger [candidate] (66.575 ms) : 0, 66575
Remote Config [baseline] (614.519 µs) : 0, 615
Remote Config [candidate] (612.836 µs) : 0, 613
Telemetry [baseline] (8.661 ms) : 0, 8661
Telemetry [candidate] (8.747 ms) : 0, 8747
Flare Poller [baseline] (3.606 ms) : 0, 3606
Flare Poller [candidate] (3.62 ms) : 0, 3620
section iast
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (804.936 ms) : 0, 804936
BytebuddyAgent [candidate] (804.684 ms) : 0, 804684
AgentMeter [baseline] (11.352 ms) : 0, 11352
AgentMeter [candidate] (11.528 ms) : 0, 11528
GlobalTracer [baseline] (239.038 ms) : 0, 239038
GlobalTracer [candidate] (240.499 ms) : 0, 240499
IAST [baseline] (25.835 ms) : 0, 25835
IAST [candidate] (25.983 ms) : 0, 25983
AppSec [baseline] (30.877 ms) : 0, 30877
AppSec [candidate] (31.989 ms) : 0, 31989
Debugger [baseline] (59.971 ms) : 0, 59971
Debugger [candidate] (60.785 ms) : 0, 60785
Remote Config [baseline] (523.108 µs) : 0, 523
Remote Config [candidate] (546.829 µs) : 0, 547
Telemetry [baseline] (13.552 ms) : 0, 13552
Telemetry [candidate] (11.974 ms) : 0, 11974
Flare Poller [baseline] (3.428 ms) : 0, 3428
Flare Poller [candidate] (3.469 ms) : 0, 3469
section profiling
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (696.589 ms) : 0, 696589
BytebuddyAgent [candidate] (693.058 ms) : 0, 693058
AgentMeter [baseline] (9.189 ms) : 0, 9189
AgentMeter [candidate] (9.142 ms) : 0, 9142
GlobalTracer [baseline] (208.647 ms) : 0, 208647
GlobalTracer [candidate] (207.225 ms) : 0, 207225
AppSec [baseline] (32.833 ms) : 0, 32833
AppSec [candidate] (32.631 ms) : 0, 32631
Debugger [baseline] (66.351 ms) : 0, 66351
Debugger [candidate] (65.829 ms) : 0, 65829
Remote Config [baseline] (579.165 µs) : 0, 579
Remote Config [candidate] (584.475 µs) : 0, 584
Telemetry [baseline] (7.984 ms) : 0, 7984
Telemetry [candidate] (7.94 ms) : 0, 7940
Flare Poller [baseline] (3.642 ms) : 0, 3642
Flare Poller [candidate] (3.624 ms) : 0, 3624
ProfilingAgent [baseline] (95.766 ms) : 0, 95766
ProfilingAgent [candidate] (94.735 ms) : 0, 94735
Profiling [baseline] (96.358 ms) : 0, 96358
Profiling [candidate] (95.31 ms) : 0, 95310
LoadParameters
See matching parameters
SummaryFound 6 performance improvements and 1 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~2578e2c1f7, baseline=1.62.0-SNAPSHOT~b266e2d0c2
dateFormat X
axisFormat %s
section baseline
no_agent (19.311 ms) : 19113, 19510
. : milestone, 19311,
appsec (18.967 ms) : 18774, 19160
. : milestone, 18967,
code_origins (18.766 ms) : 18578, 18953
. : milestone, 18766,
iast (18.036 ms) : 17860, 18213
. : milestone, 18036,
profiling (18.256 ms) : 18074, 18437
. : milestone, 18256,
tracing (18.796 ms) : 18607, 18985
. : milestone, 18796,
section candidate
no_agent (18.116 ms) : 17934, 18297
. : milestone, 18116,
appsec (18.702 ms) : 18513, 18892
. : milestone, 18702,
code_origins (17.61 ms) : 17436, 17783
. : milestone, 17610,
iast (18.385 ms) : 18202, 18569
. : milestone, 18385,
profiling (18.151 ms) : 17967, 18335
. : milestone, 18151,
tracing (17.752 ms) : 17580, 17924
. : milestone, 17752,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~2578e2c1f7, baseline=1.62.0-SNAPSHOT~b266e2d0c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.346 ms) : 1332, 1360
. : milestone, 1346,
iast (3.271 ms) : 3226, 3316
. : milestone, 3271,
iast_FULL (5.955 ms) : 5894, 6015
. : milestone, 5955,
iast_GLOBAL (3.65 ms) : 3594, 3706
. : milestone, 3650,
profiling (2.206 ms) : 2186, 2226
. : milestone, 2206,
tracing (1.903 ms) : 1886, 1919
. : milestone, 1903,
section candidate
no_agent (1.259 ms) : 1247, 1271
. : milestone, 1259,
iast (3.396 ms) : 3348, 3443
. : milestone, 3396,
iast_FULL (6.103 ms) : 6040, 6166
. : milestone, 6103,
iast_GLOBAL (3.647 ms) : 3585, 3709
. : milestone, 3647,
profiling (2.241 ms) : 2216, 2266
. : milestone, 2241,
tracing (1.922 ms) : 1906, 1939
. : milestone, 1922,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~2578e2c1f7, baseline=1.62.0-SNAPSHOT~b266e2d0c2
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.541 ms) : 2485, 2597
. : milestone, 2541,
iast (2.278 ms) : 2208, 2348
. : milestone, 2278,
iast_GLOBAL (2.323 ms) : 2252, 2393
. : milestone, 2323,
profiling (2.106 ms) : 2050, 2162
. : milestone, 2106,
tracing (2.083 ms) : 2029, 2137
. : milestone, 2083,
section candidate
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (3.808 ms) : 3586, 4031
. : milestone, 3808,
iast (2.277 ms) : 2207, 2348
. : milestone, 2277,
iast_GLOBAL (2.315 ms) : 2245, 2386
. : milestone, 2315,
profiling (2.1 ms) : 2044, 2155
. : milestone, 2100,
tracing (2.079 ms) : 2024, 2133
. : milestone, 2079,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~2578e2c1f7, baseline=1.62.0-SNAPSHOT~b266e2d0c2
dateFormat X
axisFormat %s
section baseline
no_agent (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
appsec (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
iast (18.391 s) : 18391000, 18391000
. : milestone, 18391000,
iast_GLOBAL (18.16 s) : 18160000, 18160000
. : milestone, 18160000,
profiling (14.852 s) : 14852000, 14852000
. : milestone, 14852000,
tracing (14.901 s) : 14901000, 14901000
. : milestone, 14901000,
section candidate
no_agent (15.585 s) : 15585000, 15585000
. : milestone, 15585000,
appsec (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
iast (18.297 s) : 18297000, 18297000
. : milestone, 18297000,
iast_GLOBAL (18.067 s) : 18067000, 18067000
. : milestone, 18067000,
profiling (14.785 s) : 14785000, 14785000
. : milestone, 14785000,
tracing (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
7c1b47b
into
master
What Does This Do
Source filename used in probe definition can have path using backslashes (Windows-style)
we normalize those paths before building the definition matcher
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-5109
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.