Add Integration Specific Handling for Config Inversion Linter#11074
Add Integration Specific Handling for Config Inversion Linter#11074gh-worker-dd-mergequeue-cf854d[bot] merged 16 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~579d30e237, baseline=1.62.0-SNAPSHOT~d625c6617a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064577
Total [baseline] (8.9 s) : 0, 8900113
Agent [candidate] (1.062 s) : 0, 1061546
Total [candidate] (8.825 s) : 0, 8824803
section iast
Agent [baseline] (1.24 s) : 0, 1240007
Total [baseline] (9.561 s) : 0, 9560736
Agent [candidate] (1.228 s) : 0, 1228054
Total [candidate] (9.565 s) : 0, 9565152
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~579d30e237, baseline=1.62.0-SNAPSHOT~d625c6617a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.238 ms) : 0, 1238
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (637.751 ms) : 0, 637751
BytebuddyAgent [candidate] (636.065 ms) : 0, 636065
AgentMeter [baseline] (29.748 ms) : 0, 29748
AgentMeter [candidate] (29.508 ms) : 0, 29508
GlobalTracer [baseline] (250.82 ms) : 0, 250820
GlobalTracer [candidate] (248.791 ms) : 0, 248791
AppSec [baseline] (32.775 ms) : 0, 32775
AppSec [candidate] (32.396 ms) : 0, 32396
Debugger [baseline] (59.716 ms) : 0, 59716
Debugger [candidate] (58.895 ms) : 0, 58895
Remote Config [baseline] (608.112 µs) : 0, 608
Remote Config [candidate] (601.087 µs) : 0, 601
Telemetry [baseline] (8.112 ms) : 0, 8112
Telemetry [candidate] (7.972 ms) : 0, 7972
Flare Poller [baseline] (7.55 ms) : 0, 7550
Flare Poller [candidate] (9.844 ms) : 0, 9844
section iast
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (813.521 ms) : 0, 813521
BytebuddyAgent [candidate] (803.531 ms) : 0, 803531
AgentMeter [baseline] (11.722 ms) : 0, 11722
AgentMeter [candidate] (11.607 ms) : 0, 11607
GlobalTracer [baseline] (241.27 ms) : 0, 241270
GlobalTracer [candidate] (240.163 ms) : 0, 240163
AppSec [baseline] (32.326 ms) : 0, 32326
AppSec [candidate] (32.793 ms) : 0, 32793
Debugger [baseline] (63.916 ms) : 0, 63916
Debugger [candidate] (63.112 ms) : 0, 63112
Remote Config [baseline] (534.428 µs) : 0, 534
Remote Config [candidate] (539.7 µs) : 0, 540
Telemetry [baseline] (9.489 ms) : 0, 9489
Telemetry [candidate] (9.256 ms) : 0, 9256
Flare Poller [baseline] (3.576 ms) : 0, 3576
Flare Poller [candidate] (3.641 ms) : 0, 3641
IAST [baseline] (26.027 ms) : 0, 26027
IAST [candidate] (25.908 ms) : 0, 25908
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~579d30e237, baseline=1.62.0-SNAPSHOT~d625c6617a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065551
Total [baseline] (11.097 s) : 0, 11097431
Agent [candidate] (1.059 s) : 0, 1059148
Total [candidate] (11.047 s) : 0, 11047188
section appsec
Agent [baseline] (1.259 s) : 0, 1259219
Total [baseline] (11.123 s) : 0, 11123217
Agent [candidate] (1.248 s) : 0, 1248281
Total [candidate] (11.108 s) : 0, 11108442
section iast
Agent [baseline] (1.241 s) : 0, 1241411
Total [baseline] (11.402 s) : 0, 11401880
Agent [candidate] (1.227 s) : 0, 1226911
Total [candidate] (11.392 s) : 0, 11392483
section profiling
Agent [baseline] (1.189 s) : 0, 1189281
Total [baseline] (11.079 s) : 0, 11078776
Agent [candidate] (1.192 s) : 0, 1192315
Total [candidate] (11.073 s) : 0, 11073452
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~579d30e237, baseline=1.62.0-SNAPSHOT~d625c6617a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (638.494 ms) : 0, 638494
BytebuddyAgent [candidate] (633.771 ms) : 0, 633771
AgentMeter [baseline] (29.564 ms) : 0, 29564
AgentMeter [candidate] (29.47 ms) : 0, 29470
GlobalTracer [baseline] (250.16 ms) : 0, 250160
GlobalTracer [candidate] (249.419 ms) : 0, 249419
AppSec [baseline] (32.584 ms) : 0, 32584
AppSec [candidate] (32.269 ms) : 0, 32269
Debugger [baseline] (60.194 ms) : 0, 60194
Debugger [candidate] (59.968 ms) : 0, 59968
Remote Config [baseline] (593.9 µs) : 0, 594
Remote Config [candidate] (609.231 µs) : 0, 609
Telemetry [baseline] (8.071 ms) : 0, 8071
Telemetry [candidate] (8.02 ms) : 0, 8020
Flare Poller [baseline] (8.155 ms) : 0, 8155
Flare Poller [candidate] (8.207 ms) : 0, 8207
section appsec
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.232 ms) : 0, 1232
BytebuddyAgent [baseline] (668.439 ms) : 0, 668439
BytebuddyAgent [candidate] (662.236 ms) : 0, 662236
AgentMeter [baseline] (12.375 ms) : 0, 12375
AgentMeter [candidate] (12.209 ms) : 0, 12209
GlobalTracer [baseline] (251.196 ms) : 0, 251196
GlobalTracer [candidate] (248.382 ms) : 0, 248382
AppSec [baseline] (185.906 ms) : 0, 185906
AppSec [candidate] (185.151 ms) : 0, 185151
Debugger [baseline] (66.323 ms) : 0, 66323
Debugger [candidate] (65.985 ms) : 0, 65985
Remote Config [baseline] (603.958 µs) : 0, 604
Remote Config [candidate] (622.59 µs) : 0, 623
Telemetry [baseline] (8.428 ms) : 0, 8428
Telemetry [candidate] (8.33 ms) : 0, 8330
Flare Poller [baseline] (3.534 ms) : 0, 3534
Flare Poller [candidate] (3.539 ms) : 0, 3539
IAST [baseline] (24.63 ms) : 0, 24630
IAST [candidate] (24.425 ms) : 0, 24425
section iast
crashtracking [baseline] (1.255 ms) : 0, 1255
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (813.921 ms) : 0, 813921
BytebuddyAgent [candidate] (802.289 ms) : 0, 802289
AgentMeter [baseline] (11.746 ms) : 0, 11746
AgentMeter [candidate] (11.521 ms) : 0, 11521
GlobalTracer [baseline] (241.745 ms) : 0, 241745
GlobalTracer [candidate] (240.063 ms) : 0, 240063
AppSec [baseline] (32.17 ms) : 0, 32170
AppSec [candidate] (32.159 ms) : 0, 32159
Debugger [baseline] (64.584 ms) : 0, 64584
Debugger [candidate] (64.362 ms) : 0, 64362
Remote Config [baseline] (532.037 µs) : 0, 532
Remote Config [candidate] (532.293 µs) : 0, 532
Telemetry [baseline] (9.273 ms) : 0, 9273
Telemetry [candidate] (9.372 ms) : 0, 9372
Flare Poller [baseline] (3.589 ms) : 0, 3589
Flare Poller [candidate] (3.574 ms) : 0, 3574
IAST [baseline] (26.068 ms) : 0, 26068
IAST [candidate] (25.734 ms) : 0, 25734
section profiling
ProfilingAgent [baseline] (94.441 ms) : 0, 94441
ProfilingAgent [candidate] (94.796 ms) : 0, 94796
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (693.106 ms) : 0, 693106
BytebuddyAgent [candidate] (695.009 ms) : 0, 695009
AgentMeter [baseline] (9.23 ms) : 0, 9230
AgentMeter [candidate] (9.267 ms) : 0, 9267
GlobalTracer [baseline] (208.79 ms) : 0, 208790
GlobalTracer [candidate] (209.097 ms) : 0, 209097
AppSec [baseline] (32.98 ms) : 0, 32980
AppSec [candidate] (33.072 ms) : 0, 33072
Debugger [baseline] (66.253 ms) : 0, 66253
Debugger [candidate] (66.401 ms) : 0, 66401
Remote Config [baseline] (593.373 µs) : 0, 593
Remote Config [candidate] (581.447 µs) : 0, 581
Telemetry [baseline] (7.827 ms) : 0, 7827
Telemetry [candidate] (7.896 ms) : 0, 7896
Flare Poller [baseline] (3.557 ms) : 0, 3557
Flare Poller [candidate] (3.589 ms) : 0, 3589
Profiling [baseline] (95.004 ms) : 0, 95004
Profiling [candidate] (95.366 ms) : 0, 95366
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~579d30e237, baseline=1.62.0-SNAPSHOT~d625c6617a
dateFormat X
axisFormat %s
section baseline
no_agent (1.236 ms) : 1224, 1248
. : milestone, 1236,
iast (3.64 ms) : 3589, 3690
. : milestone, 3640,
iast_FULL (5.918 ms) : 5858, 5977
. : milestone, 5918,
iast_GLOBAL (3.561 ms) : 3506, 3615
. : milestone, 3561,
profiling (2.156 ms) : 2135, 2176
. : milestone, 2156,
tracing (1.971 ms) : 1955, 1988
. : milestone, 1971,
section candidate
no_agent (1.255 ms) : 1243, 1268
. : milestone, 1255,
iast (3.278 ms) : 3234, 3321
. : milestone, 3278,
iast_FULL (5.924 ms) : 5864, 5983
. : milestone, 5924,
iast_GLOBAL (3.66 ms) : 3600, 3721
. : milestone, 3660,
profiling (2.03 ms) : 2013, 2047
. : milestone, 2030,
tracing (1.898 ms) : 1881, 1916
. : milestone, 1898,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~579d30e237, baseline=1.62.0-SNAPSHOT~d625c6617a
dateFormat X
axisFormat %s
section baseline
no_agent (18.251 ms) : 18066, 18437
. : milestone, 18251,
appsec (18.698 ms) : 18508, 18887
. : milestone, 18698,
code_origins (17.792 ms) : 17620, 17964
. : milestone, 17792,
iast (18.109 ms) : 17926, 18293
. : milestone, 18109,
profiling (19.679 ms) : 19477, 19881
. : milestone, 19679,
tracing (17.809 ms) : 17633, 17984
. : milestone, 17809,
section candidate
no_agent (17.252 ms) : 17085, 17419
. : milestone, 17252,
appsec (18.935 ms) : 18749, 19122
. : milestone, 18935,
code_origins (18.033 ms) : 17854, 18213
. : milestone, 18033,
iast (17.781 ms) : 17605, 17957
. : milestone, 17781,
profiling (18.301 ms) : 18118, 18483
. : milestone, 18301,
tracing (18.707 ms) : 18514, 18900
. : milestone, 18707,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~579d30e237, baseline=1.62.0-SNAPSHOT~d625c6617a
dateFormat X
axisFormat %s
section baseline
no_agent (15.567 s) : 15567000, 15567000
. : milestone, 15567000,
appsec (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
iast (18.483 s) : 18483000, 18483000
. : milestone, 18483000,
iast_GLOBAL (17.85 s) : 17850000, 17850000
. : milestone, 17850000,
profiling (15.377 s) : 15377000, 15377000
. : milestone, 15377000,
tracing (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
section candidate
no_agent (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
appsec (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
iast (18.498 s) : 18498000, 18498000
. : milestone, 18498000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
. : milestone, 17998000,
profiling (15.413 s) : 15413000, 15413000
. : milestone, 15413000,
tracing (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~579d30e237, baseline=1.62.0-SNAPSHOT~d625c6617a
dateFormat X
axisFormat %s
section baseline
no_agent (1.491 ms) : 1479, 1502
. : milestone, 1491,
appsec (3.86 ms) : 3636, 4084
. : milestone, 3860,
iast (2.285 ms) : 2216, 2355
. : milestone, 2285,
iast_GLOBAL (2.325 ms) : 2255, 2395
. : milestone, 2325,
profiling (2.098 ms) : 2043, 2153
. : milestone, 2098,
tracing (2.085 ms) : 2031, 2139
. : milestone, 2085,
section candidate
no_agent (1.491 ms) : 1479, 1502
. : milestone, 1491,
appsec (2.555 ms) : 2500, 2611
. : milestone, 2555,
iast (2.283 ms) : 2213, 2352
. : milestone, 2283,
iast_GLOBAL (2.328 ms) : 2258, 2397
. : milestone, 2328,
profiling (2.099 ms) : 2044, 2154
. : milestone, 2099,
tracing (2.1 ms) : 2046, 2154
. : milestone, 2100,
|
bric3
left a comment
There was a problem hiding this comment.
I'm pre approving to unblock, since it's close to be in the right shape.
I think as a future improvement for the whole config linter plugin, this plugin could have tests like some of the other plugins. I'd like us to have proper test coverage even for our custom build plugins.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This PR adds Integration-specific handling for
ConfigInversionLinter. This falls into 2 sections.Instrumentation Classes:
These define configs by extending
InstrumenterModulewhich callsConfigProviderin it's constructor w/ theinstrumentationNamepassed in. This then created the typicalDD_TRACE_<INTEGRATION>_ENABLEDflow withDD_TRACE_INTEGRATION_<INTEGRATION>_ENABLEDandDD_INTEGRATION_<INTEGRATION>_ENABLEDas aliases. TheregisterCheckInstrumenterModuleConfigurationstask handles this scenario.Decorator Classes:
These define configs by extending
BaseDecoratorwhich callsConfigProviderin it's constructor w/ using the values returned from theinstrumentationNames()function. This creates theDD_TRACE_<INTEGRATION>_ANALYTICS_ENABLEDflow withDD_<INTEGRATION>_ANALYTICS_ENABLEDas an alias, andDD_TRACE_<INTEGRATION>_ANALYTICS_SAMPLE_RATEflow withDD_<INTEGRATION>_ANALYTICS_SAMPLE_RATEas an alias. TheregisterCheckDecoratorAnalyticsConfigurationstask handles this scenario.A shared helper
registerInstrumentationCheckTaskis used to loop through each source file indd-trace-java/instrumentationand call the respective tasks afterwards.This PR also adds the new Gradle task to the
config-inversion-linterCI job.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.