Include 5xx responses in default HTTP client error statuses#11156
Draft
saravadeo wants to merge 1 commit intoDataDog:masterfrom
Draft
Include 5xx responses in default HTTP client error statuses#11156saravadeo wants to merge 1 commit intoDataDog:masterfrom
saravadeo wants to merge 1 commit intoDataDog:masterfrom
Conversation
saravadeo
force-pushed
the
fix/http-client-error-statuses-5xx
branch
from
937c00a to
2206ee2
Compare
Default client error range was 4xx only, so downstream HTTP spans did not mark 5xx responses as errors. Align defaults with server-side semantics by treating 500-599 as errors unless overridden. Fixes DataDog#10245
saravadeo
force-pushed
the
fix/http-client-error-statuses-5xx
branch
from
2206ee2 to
876a5a1
Compare
Contributor
Author
|
I don’t have permission to add labels on this repo. Could a maintainer please add the appropriate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10245
Default
DEFAULT_HTTP_CLIENT_ERROR_STATUSESnow includes HTTP 5xx so outbound client spans and downstream metrics treat server errors as span errors unless overridden viaDD_TRACE_HTTP_CLIENT_ERROR_STATUSES/DD_HTTP_CLIENT_ERROR_STATUSES.