Add support double quotes as a single token in SQLNormalizer#11197
Add support double quotes as a single token in SQLNormalizer#11197gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~61d01a2c30, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055153
Total [baseline] (8.825 s) : 0, 8824693
Agent [candidate] (1.053 s) : 0, 1053479
Total [candidate] (8.82 s) : 0, 8820038
section iast
Agent [baseline] (1.232 s) : 0, 1231699
Total [baseline] (9.512 s) : 0, 9511945
Agent [candidate] (1.234 s) : 0, 1234165
Total [candidate] (9.527 s) : 0, 9526507
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~61d01a2c30, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (634.67 ms) : 0, 634670
BytebuddyAgent [candidate] (634.076 ms) : 0, 634076
AgentMeter [baseline] (29.2 ms) : 0, 29200
AgentMeter [candidate] (29.259 ms) : 0, 29259
GlobalTracer [baseline] (248.436 ms) : 0, 248436
GlobalTracer [candidate] (248.16 ms) : 0, 248160
AppSec [baseline] (32.325 ms) : 0, 32325
AppSec [candidate] (32.223 ms) : 0, 32223
Debugger [baseline] (59.461 ms) : 0, 59461
Debugger [candidate] (59.485 ms) : 0, 59485
Remote Config [baseline] (603.438 µs) : 0, 603
Remote Config [candidate] (618.484 µs) : 0, 618
Telemetry [baseline] (9.527 ms) : 0, 9527
Telemetry [candidate] (8.773 ms) : 0, 8773
Flare Poller [baseline] (3.565 ms) : 0, 3565
Flare Poller [candidate] (3.571 ms) : 0, 3571
section iast
crashtracking [baseline] (1.249 ms) : 0, 1249
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (809.501 ms) : 0, 809501
BytebuddyAgent [candidate] (813.084 ms) : 0, 813084
AgentMeter [baseline] (11.378 ms) : 0, 11378
AgentMeter [candidate] (11.435 ms) : 0, 11435
GlobalTracer [baseline] (239.163 ms) : 0, 239163
GlobalTracer [candidate] (238.981 ms) : 0, 238981
IAST [baseline] (29.343 ms) : 0, 29343
IAST [candidate] (29.157 ms) : 0, 29157
AppSec [baseline] (26.947 ms) : 0, 26947
AppSec [candidate] (30.04 ms) : 0, 30040
Debugger [baseline] (66.321 ms) : 0, 66321
Debugger [candidate] (62.546 ms) : 0, 62546
Remote Config [baseline] (541.662 µs) : 0, 542
Remote Config [candidate] (534.167 µs) : 0, 534
Telemetry [baseline] (7.756 ms) : 0, 7756
Telemetry [candidate] (7.77 ms) : 0, 7770
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (3.408 ms) : 0, 3408
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~61d01a2c30, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055739
Total [baseline] (11.069 s) : 0, 11069342
Agent [candidate] (1.064 s) : 0, 1063773
Total [candidate] (11.052 s) : 0, 11051974
section appsec
Agent [baseline] (1.266 s) : 0, 1265669
Total [baseline] (11.197 s) : 0, 11196880
Agent [candidate] (1.263 s) : 0, 1263467
Total [candidate] (11.017 s) : 0, 11017271
section iast
Agent [baseline] (1.239 s) : 0, 1239245
Total [baseline] (11.273 s) : 0, 11272885
Agent [candidate] (1.23 s) : 0, 1230362
Total [candidate] (11.318 s) : 0, 11318226
section profiling
Agent [baseline] (1.186 s) : 0, 1185808
Total [baseline] (10.937 s) : 0, 10936830
Agent [candidate] (1.185 s) : 0, 1185037
Total [candidate] (11.007 s) : 0, 11007136
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~61d01a2c30, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.23 ms) : 0, 1230
BytebuddyAgent [baseline] (635.407 ms) : 0, 635407
BytebuddyAgent [candidate] (640.302 ms) : 0, 640302
AgentMeter [baseline] (29.367 ms) : 0, 29367
AgentMeter [candidate] (29.603 ms) : 0, 29603
GlobalTracer [baseline] (248.945 ms) : 0, 248945
GlobalTracer [candidate] (249.874 ms) : 0, 249874
AppSec [baseline] (32.311 ms) : 0, 32311
AppSec [candidate] (32.193 ms) : 0, 32193
Debugger [baseline] (60.292 ms) : 0, 60292
Debugger [candidate] (60.458 ms) : 0, 60458
Remote Config [baseline] (586.887 µs) : 0, 587
Remote Config [candidate] (595.462 µs) : 0, 595
Telemetry [baseline] (8.009 ms) : 0, 8009
Telemetry [candidate] (8.791 ms) : 0, 8791
Flare Poller [baseline] (3.511 ms) : 0, 3511
Flare Poller [candidate] (4.355 ms) : 0, 4355
section appsec
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (676.264 ms) : 0, 676264
BytebuddyAgent [candidate] (675.987 ms) : 0, 675987
AgentMeter [baseline] (12.27 ms) : 0, 12270
AgentMeter [candidate] (12.256 ms) : 0, 12256
GlobalTracer [baseline] (249.771 ms) : 0, 249771
GlobalTracer [candidate] (249.42 ms) : 0, 249420
IAST [baseline] (24.201 ms) : 0, 24201
IAST [candidate] (24.217 ms) : 0, 24217
AppSec [baseline] (186.492 ms) : 0, 186492
AppSec [candidate] (186.476 ms) : 0, 186476
Debugger [baseline] (66.848 ms) : 0, 66848
Debugger [candidate] (65.679 ms) : 0, 65679
Remote Config [baseline] (595.962 µs) : 0, 596
Remote Config [candidate] (586.281 µs) : 0, 586
Telemetry [baseline] (8.025 ms) : 0, 8025
Telemetry [candidate] (7.874 ms) : 0, 7874
Flare Poller [baseline] (3.538 ms) : 0, 3538
Flare Poller [candidate] (3.453 ms) : 0, 3453
section iast
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (813.737 ms) : 0, 813737
BytebuddyAgent [candidate] (808.835 ms) : 0, 808835
AgentMeter [baseline] (11.471 ms) : 0, 11471
AgentMeter [candidate] (11.361 ms) : 0, 11361
GlobalTracer [baseline] (240.914 ms) : 0, 240914
GlobalTracer [candidate] (238.915 ms) : 0, 238915
IAST [baseline] (28.547 ms) : 0, 28547
IAST [candidate] (30.72 ms) : 0, 30720
AppSec [baseline] (28.79 ms) : 0, 28790
AppSec [candidate] (27.463 ms) : 0, 27463
Debugger [baseline] (66.595 ms) : 0, 66595
Debugger [candidate] (64.206 ms) : 0, 64206
Remote Config [baseline] (550.594 µs) : 0, 551
Remote Config [candidate] (523.979 µs) : 0, 524
Telemetry [baseline] (7.88 ms) : 0, 7880
Telemetry [candidate] (7.717 ms) : 0, 7717
Flare Poller [baseline] (3.509 ms) : 0, 3509
Flare Poller [candidate] (3.369 ms) : 0, 3369
section profiling
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (692.767 ms) : 0, 692767
BytebuddyAgent [candidate] (692.848 ms) : 0, 692848
AgentMeter [baseline] (8.991 ms) : 0, 8991
AgentMeter [candidate] (8.982 ms) : 0, 8982
GlobalTracer [baseline] (207.895 ms) : 0, 207895
GlobalTracer [candidate] (207.842 ms) : 0, 207842
AppSec [baseline] (32.652 ms) : 0, 32652
AppSec [candidate] (32.553 ms) : 0, 32553
Debugger [baseline] (65.749 ms) : 0, 65749
Debugger [candidate] (64.471 ms) : 0, 64471
Remote Config [baseline] (573.192 µs) : 0, 573
Remote Config [candidate] (564.369 µs) : 0, 564
Telemetry [baseline] (7.739 ms) : 0, 7739
Telemetry [candidate] (7.76 ms) : 0, 7760
Flare Poller [baseline] (3.469 ms) : 0, 3469
Flare Poller [candidate] (4.271 ms) : 0, 4271
ProfilingAgent [baseline] (93.222 ms) : 0, 93222
ProfilingAgent [candidate] (93.008 ms) : 0, 93008
Profiling [baseline] (93.775 ms) : 0, 93775
Profiling [candidate] (93.569 ms) : 0, 93569
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~61d01a2c30, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section baseline
no_agent (1.246 ms) : 1233, 1259
. : milestone, 1246,
iast (3.231 ms) : 3185, 3276
. : milestone, 3231,
iast_FULL (6.002 ms) : 5942, 6062
. : milestone, 6002,
iast_GLOBAL (3.627 ms) : 3568, 3686
. : milestone, 3627,
profiling (2.148 ms) : 2126, 2170
. : milestone, 2148,
tracing (1.926 ms) : 1909, 1942
. : milestone, 1926,
section candidate
no_agent (1.229 ms) : 1217, 1241
. : milestone, 1229,
iast (3.351 ms) : 3307, 3396
. : milestone, 3351,
iast_FULL (6.207 ms) : 6143, 6272
. : milestone, 6207,
iast_GLOBAL (3.752 ms) : 3689, 3815
. : milestone, 3752,
profiling (2.158 ms) : 2137, 2179
. : milestone, 2158,
tracing (1.924 ms) : 1907, 1940
. : milestone, 1924,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~61d01a2c30, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section baseline
no_agent (19.431 ms) : 19230, 19631
. : milestone, 19431,
appsec (18.365 ms) : 18180, 18551
. : milestone, 18365,
code_origins (18.199 ms) : 18017, 18381
. : milestone, 18199,
iast (17.83 ms) : 17655, 18006
. : milestone, 17830,
profiling (19.299 ms) : 19107, 19491
. : milestone, 19299,
tracing (19.052 ms) : 18858, 19246
. : milestone, 19052,
section candidate
no_agent (18.152 ms) : 17970, 18334
. : milestone, 18152,
appsec (18.946 ms) : 18753, 19139
. : milestone, 18946,
code_origins (17.954 ms) : 17777, 18132
. : milestone, 17954,
iast (18.093 ms) : 17915, 18272
. : milestone, 18093,
profiling (18.456 ms) : 18275, 18638
. : milestone, 18456,
tracing (17.847 ms) : 17669, 18025
. : milestone, 17847,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~61d01a2c30, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section baseline
no_agent (15.477 s) : 15477000, 15477000
. : milestone, 15477000,
appsec (14.499 s) : 14499000, 14499000
. : milestone, 14499000,
iast (18.22 s) : 18220000, 18220000
. : milestone, 18220000,
iast_GLOBAL (17.934 s) : 17934000, 17934000
. : milestone, 17934000,
profiling (14.825 s) : 14825000, 14825000
. : milestone, 14825000,
tracing (15.295 s) : 15295000, 15295000
. : milestone, 15295000,
section candidate
no_agent (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
appsec (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
iast (18.164 s) : 18164000, 18164000
. : milestone, 18164000,
iast_GLOBAL (18.028 s) : 18028000, 18028000
. : milestone, 18028000,
profiling (15.035 s) : 15035000, 15035000
. : milestone, 15035000,
tracing (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~61d01a2c30, baseline=1.62.0-SNAPSHOT~0d1c44d515b
dateFormat X
axisFormat %s
section baseline
no_agent (1.493 ms) : 1482, 1505
. : milestone, 1493,
appsec (3.783 ms) : 3565, 4001
. : milestone, 3783,
iast (2.282 ms) : 2212, 2352
. : milestone, 2282,
iast_GLOBAL (2.325 ms) : 2254, 2396
. : milestone, 2325,
profiling (2.111 ms) : 2056, 2167
. : milestone, 2111,
tracing (2.096 ms) : 2042, 2151
. : milestone, 2096,
section candidate
no_agent (1.499 ms) : 1487, 1510
. : milestone, 1499,
appsec (3.81 ms) : 3586, 4034
. : milestone, 3810,
iast (2.282 ms) : 2212, 2352
. : milestone, 2282,
iast_GLOBAL (2.338 ms) : 2267, 2409
. : milestone, 2338,
profiling (2.099 ms) : 2043, 2154
. : milestone, 2099,
tracing (2.099 ms) : 2045, 2153
. : milestone, 2099,
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0fbac1afe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ygree
left a comment
There was a problem hiding this comment.
Looks good but needs some clarification
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What Does This Do
Treat
CLOSE "this is one token"as two tokens, just like for single quotes.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-19336
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.