Skip to content

Improve trace assert API#11209

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
bbujon/groovy-to-java-instrumented-tests
Apr 28, 2026
Merged

Improve trace assert API#11209
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
bbujon/groovy-to-java-instrumented-tests

Conversation

@PerfectSlayer
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer commented Apr 27, 2026

What Does This Do

This PR add traced ID evaluation and improve API (Function<U, U> to UnaryOperator<U>).

Motivation

Additional Notes

This PR is part of some bigger improvements in stacked PRs:

Contributor Checklist

Jira ticket: APMLP-1247

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

*/
/** Ignores addition traces. If there are more traces than expected, do not fail. */
public static final Function<Options, Options> IGNORE_ADDITIONAL_TRACES =
public static final UnaryOperator<Options> IGNORE_ADDITIONAL_TRACES =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figured out I was using it wrong during a Devoxx talk when I saw howe they implemented StructuredTaskScope Ruby-style builder 😬 Not too late to fit it 😇

@PerfectSlayer
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Apr 28, 2026

View all feedbacks in Devflow UI.

2026-04-28 13:15:17 UTC ℹ️ Start processing command /merge


2026-04-28 13:15:23 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-04-28 14:29:09 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 1b63a9d into master Apr 28, 2026
577 of 588 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bbujon/groovy-to-java-instrumented-tests branch April 28, 2026 14:29
@github-actions github-actions Bot added this to the 1.62.0 milestone Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants