Migrate OtlpWriterCombinedTest from groovy to junit by mtoffl01 · Pull Request #11245 · DataDog/dd-trace-java

mtoffl01 · 2026-04-30T14:41:57Z

Motivation

A previous PR introduced new test file OtlpWriterCombinedTest.groovy. This PR migrates that test to junit as per the ongoing migration.

Additional Notes

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

…, plus related tests

…RTER=otlp

amarziali · 2026-04-30T14:44:24Z

+
+  @Test
+  void happyPathOverHttp() throws IOException, InterruptedException {
+    injectSysConfig(TRACE_OTEL_EXPORTER, "otlp");


you can alternatively annotate the test method like that: @WithConfig(key = "service", value = "my_service")

oh! this is great to know.

amarziali

thanks for the effort!

sarahchen6

-1 Groovy, +1 JUnit 🎉

pr-commenter · 2026-04-30T15:27:40Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/junit-otlp-test
git_commit_date	1777386837	1777560016
git_commit_sha	`e6cac64`	`a09c99e`
release_version	1.62.0-SNAPSHOT~e6cac64dfd	1.62.0-SNAPSHOT~a09c99e6ad

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1777561843	1777561843
ci_job_id	1646597022	1646597022
ci_pipeline_id	110719350	110719350
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-vk1xstba 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-vk1xstba 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~a09c99e6ad, baseline=1.62.0-SNAPSHOT~e6cac64dfd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071938
Total [baseline] (8.845 s) : 0, 8845469
Agent [candidate] (1.063 s) : 0, 1063337
Total [candidate] (8.834 s) : 0, 8834173
section iast
Agent [baseline] (1.245 s) : 0, 1244614
Total [baseline] (9.556 s) : 0, 9555751
Agent [candidate] (1.248 s) : 0, 1247513
Total [candidate] (9.531 s) : 0, 9530964

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.072 s	-
Agent	iast	1.245 s	172.676 ms (16.1%)
Total	tracing	8.845 s	-
Total	iast	9.556 s	710.283 ms (8.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	iast	1.248 s	184.177 ms (17.3%)
Total	tracing	8.834 s	-
Total	iast	9.531 s	696.791 ms (7.9%)

gantt
    title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~a09c99e6ad, baseline=1.62.0-SNAPSHOT~e6cac64dfd

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (641.272 ms) : 0, 641272
BytebuddyAgent [candidate] (636.528 ms) : 0, 636528
AgentMeter [baseline] (29.58 ms) : 0, 29580
AgentMeter [candidate] (29.543 ms) : 0, 29543
GlobalTracer [baseline] (250.218 ms) : 0, 250218
GlobalTracer [candidate] (248.955 ms) : 0, 248955
AppSec [baseline] (33.213 ms) : 0, 33213
AppSec [candidate] (32.711 ms) : 0, 32711
Debugger [baseline] (60.41 ms) : 0, 60410
Debugger [candidate] (59.712 ms) : 0, 59712
Remote Config [baseline] (613.451 µs) : 0, 613
Remote Config [candidate] (601.993 µs) : 0, 602
Telemetry [baseline] (10.092 ms) : 0, 10092
Telemetry [candidate] (10.687 ms) : 0, 10687
Flare Poller [baseline] (9.215 ms) : 0, 9215
Flare Poller [candidate] (7.422 ms) : 0, 7422
section iast
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.239 ms) : 0, 1239
BytebuddyAgent [baseline] (822.871 ms) : 0, 822871
BytebuddyAgent [candidate] (826.049 ms) : 0, 826049
AgentMeter [baseline] (11.345 ms) : 0, 11345
AgentMeter [candidate] (11.289 ms) : 0, 11289
GlobalTracer [baseline] (238.456 ms) : 0, 238456
GlobalTracer [candidate] (238.881 ms) : 0, 238881
AppSec [baseline] (29.991 ms) : 0, 29991
AppSec [candidate] (32.241 ms) : 0, 32241
Debugger [baseline] (63.511 ms) : 0, 63511
Debugger [candidate] (62.4 ms) : 0, 62400
Remote Config [baseline] (532.77 µs) : 0, 533
Remote Config [candidate] (519.169 µs) : 0, 519
Telemetry [baseline] (8.047 ms) : 0, 8047
Telemetry [candidate] (7.899 ms) : 0, 7899
Flare Poller [baseline] (3.4 ms) : 0, 3400
Flare Poller [candidate] (3.342 ms) : 0, 3342
IAST [baseline] (29.213 ms) : 0, 29213
IAST [candidate] (27.493 ms) : 0, 27493

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~a09c99e6ad, baseline=1.62.0-SNAPSHOT~e6cac64dfd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067142
Total [baseline] (11.108 s) : 0, 11108497
Agent [candidate] (1.07 s) : 0, 1069614
Total [candidate] (10.991 s) : 0, 10990566
section appsec
Agent [baseline] (1.273 s) : 0, 1273043
Total [baseline] (11.022 s) : 0, 11022463
Agent [candidate] (1.266 s) : 0, 1265541
Total [candidate] (11.03 s) : 0, 11029692
section iast
Agent [baseline] (1.248 s) : 0, 1247521
Total [baseline] (11.215 s) : 0, 11215472
Agent [candidate] (1.244 s) : 0, 1243662
Total [candidate] (11.284 s) : 0, 11283912
section profiling
Agent [baseline] (1.188 s) : 0, 1187683
Total [baseline] (10.917 s) : 0, 10916694
Agent [candidate] (1.186 s) : 0, 1186333
Total [candidate] (10.963 s) : 0, 10963427

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.067 s	-
Agent	appsec	1.273 s	205.901 ms (19.3%)
Agent	iast	1.248 s	180.379 ms (16.9%)
Agent	profiling	1.188 s	120.541 ms (11.3%)
Total	tracing	11.108 s	-
Total	appsec	11.022 s	-86.034 ms (-0.8%)
Total	iast	11.215 s	106.974 ms (1.0%)
Total	profiling	10.917 s	-191.804 ms (-1.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.07 s	-
Agent	appsec	1.266 s	195.927 ms (18.3%)
Agent	iast	1.244 s	174.048 ms (16.3%)
Agent	profiling	1.186 s	116.719 ms (10.9%)
Total	tracing	10.991 s	-
Total	appsec	11.03 s	39.127 ms (0.4%)
Total	iast	11.284 s	293.346 ms (2.7%)
Total	profiling	10.963 s	-27.138 ms (-0.2%)

gantt
    title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~a09c99e6ad, baseline=1.62.0-SNAPSHOT~e6cac64dfd

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.232 ms) : 0, 1232
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (638.088 ms) : 0, 638088
BytebuddyAgent [candidate] (639.016 ms) : 0, 639016
AgentMeter [baseline] (29.489 ms) : 0, 29489
AgentMeter [candidate] (29.646 ms) : 0, 29646
GlobalTracer [baseline] (249.603 ms) : 0, 249603
GlobalTracer [candidate] (249.498 ms) : 0, 249498
AppSec [baseline] (33.07 ms) : 0, 33070
AppSec [candidate] (32.999 ms) : 0, 32999
Debugger [baseline] (60.788 ms) : 0, 60788
Debugger [candidate] (60.765 ms) : 0, 60765
Remote Config [baseline] (599.475 µs) : 0, 599
Remote Config [candidate] (604.287 µs) : 0, 604
Telemetry [baseline] (9.995 ms) : 0, 9995
Telemetry [candidate] (10.726 ms) : 0, 10726
Flare Poller [baseline] (8.242 ms) : 0, 8242
Flare Poller [candidate] (9.04 ms) : 0, 9040
section appsec
crashtracking [baseline] (1.234 ms) : 0, 1234
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (680.111 ms) : 0, 680111
BytebuddyAgent [candidate] (674.82 ms) : 0, 674820
AgentMeter [baseline] (12.36 ms) : 0, 12360
AgentMeter [candidate] (12.191 ms) : 0, 12191
GlobalTracer [baseline] (250.941 ms) : 0, 250941
GlobalTracer [candidate] (249.204 ms) : 0, 249204
AppSec [baseline] (186.019 ms) : 0, 186019
AppSec [candidate] (185.464 ms) : 0, 185464
Debugger [baseline] (64.872 ms) : 0, 64872
Debugger [candidate] (64.631 ms) : 0, 64631
Remote Config [baseline] (569.485 µs) : 0, 569
Remote Config [candidate] (566.241 µs) : 0, 566
Telemetry [baseline] (7.826 ms) : 0, 7826
Telemetry [candidate] (7.805 ms) : 0, 7805
Flare Poller [baseline] (7.377 ms) : 0, 7377
Flare Poller [candidate] (6.631 ms) : 0, 6631
IAST [baseline] (24.918 ms) : 0, 24918
IAST [candidate] (24.712 ms) : 0, 24712
section iast
crashtracking [baseline] (1.244 ms) : 0, 1244
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (826.892 ms) : 0, 826892
BytebuddyAgent [candidate] (823.473 ms) : 0, 823473
AgentMeter [baseline] (11.29 ms) : 0, 11290
AgentMeter [candidate] (11.309 ms) : 0, 11309
GlobalTracer [baseline] (237.237 ms) : 0, 237237
GlobalTracer [candidate] (237.499 ms) : 0, 237499
AppSec [baseline] (31.284 ms) : 0, 31284
AppSec [candidate] (30.479 ms) : 0, 30479
Debugger [baseline] (63.417 ms) : 0, 63417
Debugger [candidate] (62.99 ms) : 0, 62990
Remote Config [baseline] (528.087 µs) : 0, 528
Remote Config [candidate] (518.242 µs) : 0, 518
Telemetry [baseline] (8.012 ms) : 0, 8012
Telemetry [candidate] (7.985 ms) : 0, 7985
Flare Poller [baseline] (3.455 ms) : 0, 3455
Flare Poller [candidate] (3.353 ms) : 0, 3353
IAST [baseline] (28.037 ms) : 0, 28037
IAST [candidate] (28.813 ms) : 0, 28813
section profiling
ProfilingAgent [baseline] (93.757 ms) : 0, 93757
ProfilingAgent [candidate] (94.084 ms) : 0, 94084
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (693.16 ms) : 0, 693160
BytebuddyAgent [candidate] (692.06 ms) : 0, 692060
AgentMeter [baseline] (8.958 ms) : 0, 8958
AgentMeter [candidate] (8.908 ms) : 0, 8908
GlobalTracer [baseline] (208.181 ms) : 0, 208181
GlobalTracer [candidate] (207.844 ms) : 0, 207844
AppSec [baseline] (32.737 ms) : 0, 32737
AppSec [candidate] (32.694 ms) : 0, 32694
Debugger [baseline] (65.989 ms) : 0, 65989
Debugger [candidate] (65.93 ms) : 0, 65930
Remote Config [baseline] (568.556 µs) : 0, 569
Remote Config [candidate] (570.205 µs) : 0, 570
Telemetry [baseline] (8.092 ms) : 0, 8092
Telemetry [candidate] (8.141 ms) : 0, 8141
Flare Poller [baseline] (3.558 ms) : 0, 3558
Flare Poller [candidate] (3.543 ms) : 0, 3543
Profiling [baseline] (94.31 ms) : 0, 94310
Profiling [candidate] (94.631 ms) : 0, 94631

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/junit-otlp-test
git_commit_date	1777386837	1777560016
git_commit_sha	`e6cac64`	`a09c99e`
release_version	1.62.0-SNAPSHOT~e6cac64dfd	1.62.0-SNAPSHOT~a09c99e6ad

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1777562329	1777562329
ci_job_id	1646597024	1646597024
ci_pipeline_id	110719350	110719350
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-pe9l0dye 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-pe9l0dye 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	better [-251.341µs; -133.669µs] or [-12.732%; -6.771%]	unstable [-1411.228µs; -576.984µs] or [-22.838%; -9.337%]	unstable [+100.395op/s; +514.980op/s] or [+5.785%; +29.673%]	1.782ms	5.185ms	2043.188op/s	1.974ms	6.179ms	1735.500op/s
scenario:load:insecure-bank:iast:high_load	better [-151.372µs; -73.695µs] or [-5.482%; -2.669%]	unstable [-1363.912µs; +215.740µs] or [-16.518%; +2.613%]	unstable [-89.321op/s; +204.821op/s] or [-6.902%; +15.826%]	2.649ms	7.683ms	1351.969op/s	2.761ms	8.257ms	1294.219op/s
scenario:load:petclinic:profiling:high_load	worse [+0.828ms; +2.024ms] or [+4.663%; +11.394%]	unsure [+0.570ms; +2.224ms] or [+1.941%; +7.569%]	unstable [-42.015op/s; +12.827op/s] or [-16.523%; +5.044%]	19.186ms	30.780ms	239.688op/s	17.760ms	29.383ms	254.281op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~a09c99e6ad, baseline=1.62.0-SNAPSHOT~e6cac64dfd
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.14 ms) : 18943, 19337
.   : milestone, 19140,
appsec (18.676 ms) : 18487, 18865
.   : milestone, 18676,
code_origins (17.699 ms) : 17525, 17872
.   : milestone, 17699,
iast (18.114 ms) : 17935, 18293
.   : milestone, 18114,
profiling (18.354 ms) : 18170, 18537
.   : milestone, 18354,
tracing (18.273 ms) : 18093, 18452
.   : milestone, 18273,
section candidate
no_agent (19.21 ms) : 19016, 19405
.   : milestone, 19210,
appsec (18.66 ms) : 18474, 18847
.   : milestone, 18660,
code_origins (17.789 ms) : 17614, 17963
.   : milestone, 17789,
iast (17.964 ms) : 17789, 18140
.   : milestone, 17964,
profiling (19.474 ms) : 19275, 19673
.   : milestone, 19474,
tracing (17.857 ms) : 17682, 18032
.   : milestone, 17857,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.14 ms [18.943 ms, 19.337 ms]	-
appsec	18.676 ms [18.487 ms, 18.865 ms]	-464.116 µs (-2.4%)
code_origins	17.699 ms [17.525 ms, 17.872 ms]	-1.441 ms (-7.5%)
iast	18.114 ms [17.935 ms, 18.293 ms]	-1.026 ms (-5.4%)
profiling	18.354 ms [18.17 ms, 18.537 ms]	-786.336 µs (-4.1%)
tracing	18.273 ms [18.093 ms, 18.452 ms]	-867.26 µs (-4.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.21 ms [19.016 ms, 19.405 ms]	-
appsec	18.66 ms [18.474 ms, 18.847 ms]	-550.312 µs (-2.9%)
code_origins	17.789 ms [17.614 ms, 17.963 ms]	-1.422 ms (-7.4%)
iast	17.964 ms [17.789 ms, 18.14 ms]	-1.246 ms (-6.5%)
profiling	19.474 ms [19.275 ms, 19.673 ms]	263.743 µs (1.4%)
tracing	17.857 ms [17.682 ms, 18.032 ms]	-1.353 ms (-7.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~a09c99e6ad, baseline=1.62.0-SNAPSHOT~e6cac64dfd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.236 ms) : 1225, 1247
.   : milestone, 1236,
iast (3.54 ms) : 3482, 3598
.   : milestone, 3540,
iast_FULL (5.994 ms) : 5933, 6055
.   : milestone, 5994,
iast_GLOBAL (3.716 ms) : 3654, 3778
.   : milestone, 3716,
profiling (2.62 ms) : 2595, 2646
.   : milestone, 2620,
tracing (1.917 ms) : 1901, 1934
.   : milestone, 1917,
section candidate
no_agent (1.241 ms) : 1229, 1253
.   : milestone, 1241,
iast (3.387 ms) : 3339, 3434
.   : milestone, 3387,
iast_FULL (5.809 ms) : 5751, 5867
.   : milestone, 5809,
iast_GLOBAL (3.667 ms) : 3607, 3728
.   : milestone, 3667,
profiling (2.215 ms) : 2195, 2235
.   : milestone, 2215,
tracing (1.898 ms) : 1882, 1914
.   : milestone, 1898,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.236 ms [1.225 ms, 1.247 ms]	-
iast	3.54 ms [3.482 ms, 3.598 ms]	2.304 ms (186.4%)
iast_FULL	5.994 ms [5.933 ms, 6.055 ms]	4.758 ms (384.9%)
iast_GLOBAL	3.716 ms [3.654 ms, 3.778 ms]	2.48 ms (200.6%)
profiling	2.62 ms [2.595 ms, 2.646 ms]	1.384 ms (112.0%)
tracing	1.917 ms [1.901 ms, 1.934 ms]	681.219 µs (55.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.241 ms [1.229 ms, 1.253 ms]	-
iast	3.387 ms [3.339 ms, 3.434 ms]	2.146 ms (173.0%)
iast_FULL	5.809 ms [5.751 ms, 5.867 ms]	4.568 ms (368.2%)
iast_GLOBAL	3.667 ms [3.607 ms, 3.728 ms]	2.427 ms (195.6%)
profiling	2.215 ms [2.195 ms, 2.235 ms]	974.603 µs (78.6%)
tracing	1.898 ms [1.882 ms, 1.914 ms]	657.122 µs (53.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/junit-otlp-test
git_commit_date	1777386837	1777560016
git_commit_sha	`e6cac64`	`a09c99e`
release_version	1.62.0-SNAPSHOT~e6cac64dfd	1.62.0-SNAPSHOT~a09c99e6ad

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1777562151	1777562151
ci_job_id	1646597027	1646597027
ci_pipeline_id	110719350	110719350
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-7u53nf22 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-7u53nf22 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~a09c99e6ad, baseline=1.62.0-SNAPSHOT~e6cac64dfd
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.073 s) : 15073000, 15073000
.   : milestone, 15073000,
appsec (14.906 s) : 14906000, 14906000
.   : milestone, 14906000,
iast (18.284 s) : 18284000, 18284000
.   : milestone, 18284000,
iast_GLOBAL (17.773 s) : 17773000, 17773000
.   : milestone, 17773000,
profiling (14.75 s) : 14750000, 14750000
.   : milestone, 14750000,
tracing (14.787 s) : 14787000, 14787000
.   : milestone, 14787000,
section candidate
no_agent (14.892 s) : 14892000, 14892000
.   : milestone, 14892000,
appsec (14.939 s) : 14939000, 14939000
.   : milestone, 14939000,
iast (18.19 s) : 18190000, 18190000
.   : milestone, 18190000,
iast_GLOBAL (17.838 s) : 17838000, 17838000
.   : milestone, 17838000,
profiling (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
tracing (14.815 s) : 14815000, 14815000
.   : milestone, 14815000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.073 s [15.073 s, 15.073 s]	-
appsec	14.906 s [14.906 s, 14.906 s]	-167.0 ms (-1.1%)
iast	18.284 s [18.284 s, 18.284 s]	3.211 s (21.3%)
iast_GLOBAL	17.773 s [17.773 s, 17.773 s]	2.7 s (17.9%)
profiling	14.75 s [14.75 s, 14.75 s]	-323.0 ms (-2.1%)
tracing	14.787 s [14.787 s, 14.787 s]	-286.0 ms (-1.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.892 s [14.892 s, 14.892 s]	-
appsec	14.939 s [14.939 s, 14.939 s]	47.0 ms (0.3%)
iast	18.19 s [18.19 s, 18.19 s]	3.298 s (22.1%)
iast_GLOBAL	17.838 s [17.838 s, 17.838 s]	2.946 s (19.8%)
profiling	14.962 s [14.962 s, 14.962 s]	70.0 ms (0.5%)
tracing	14.815 s [14.815 s, 14.815 s]	-77.0 ms (-0.5%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~a09c99e6ad, baseline=1.62.0-SNAPSHOT~e6cac64dfd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.5 ms) : 1488, 1512
.   : milestone, 1500,
appsec (2.566 ms) : 2511, 2621
.   : milestone, 2566,
iast (2.296 ms) : 2226, 2366
.   : milestone, 2296,
iast_GLOBAL (2.33 ms) : 2260, 2400
.   : milestone, 2330,
profiling (2.111 ms) : 2057, 2166
.   : milestone, 2111,
tracing (2.085 ms) : 2032, 2139
.   : milestone, 2085,
section candidate
no_agent (1.499 ms) : 1487, 1511
.   : milestone, 1499,
appsec (3.825 ms) : 3604, 4047
.   : milestone, 3825,
iast (2.297 ms) : 2227, 2367
.   : milestone, 2297,
iast_GLOBAL (2.337 ms) : 2266, 2407
.   : milestone, 2337,
profiling (2.124 ms) : 2068, 2179
.   : milestone, 2124,
tracing (2.082 ms) : 2028, 2136
.   : milestone, 2082,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.5 ms [1.488 ms, 1.512 ms]	-
appsec	2.566 ms [2.511 ms, 2.621 ms]	1.066 ms (71.1%)
iast	2.296 ms [2.226 ms, 2.366 ms]	796.062 µs (53.1%)
iast_GLOBAL	2.33 ms [2.26 ms, 2.4 ms]	830.311 µs (55.4%)
profiling	2.111 ms [2.057 ms, 2.166 ms]	611.486 µs (40.8%)
tracing	2.085 ms [2.032 ms, 2.139 ms]	585.39 µs (39.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.499 ms [1.487 ms, 1.511 ms]	-
appsec	3.825 ms [3.604 ms, 4.047 ms]	2.326 ms (155.2%)
iast	2.297 ms [2.227 ms, 2.367 ms]	798.019 µs (53.2%)
iast_GLOBAL	2.337 ms [2.266 ms, 2.407 ms]	837.811 µs (55.9%)
profiling	2.124 ms [2.068 ms, 2.179 ms]	624.633 µs (41.7%)
tracing	2.082 ms [2.028 ms, 2.136 ms]	582.99 µs (38.9%)

mcculls · 2026-04-30T15:53:56Z

Can you merge/rebase onto latest master - that will cleanup the commits for the already merged OTLP code and also fix the muzzle failure

mcculls

LGTM - you can simplify it by using @WithConfig as Andrea pointed out

Also remember to delete the old OtlpWriterCombinedTest.groovy which this replaces.

dd-octo-sts · 2026-04-30T18:10:33Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-04-30T18:10:37Z

View all feedbacks in Devflow UI.

2026-04-30 18:10:37 UTC ℹ️ Start processing command /merge

2026-04-30 18:10:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-04-30 19:30:03 UTC ℹ️ MergeQueue: This merge request was merged

mtoffl01 added 20 commits April 28, 2026 14:57

Introduce isTraceOtlpExporterEnabled branching logic for Sampler.java…

145f884

…, plus related tests

Include regression test for UNSET spans in otlp mode

d183f39

Create new OTLP writer type, enabled by default when OTEL_TRACES_EXPO…

d69e491

…RTER=otlp

Implement OtlpPayloadDispatcher.java

e7e3a95

Introduce OtlpPayloadDispatcherTest.java

af97659

Implement OtlpWriter

015e272

Introduce OtlpWriterTest.java

8194971

Introduce OtlpWriterCombinedTest.java with a TODO

a5cd8fe

WriterFactory: Add OTLP branch for OtlpWriter; include a TODO for a test

1615566

nits

46887fe

Implement OtlpWriter tests in WriterFactoryTest

eb2b116

Document problems with OtlpWriterCombinedTest

b02aab1

fill NPE on writeSpanTag

594b4b8

Regression test for UNSET spans in otlp writer mode

491533b

fix grpc path for OtlpWriter and OtlpSender - plus a regression test

53d53d7

Remove OtlpTraceProtoCollector INSTANCE singleton

edc1081

Implement happy path test in OtlpWriterCombinedTest

5acc0d9

Test the OTLP http request body in OtlpHttpRequestBodyTest

2456c8b

Fix NPE on null span type tag, and add regression test

96954d7

migrate OtlpWriterCombinedTest to junit

a09c99e

mtoffl01 requested a review from sarahchen6 April 30, 2026 14:42

mtoffl01 marked this pull request as ready for review April 30, 2026 14:42

mtoffl01 requested a review from a team as a code owner April 30, 2026 14:42

mtoffl01 requested a review from amarziali April 30, 2026 14:42

mtoffl01 added comp: testing Testing type: refactoring tag: ai generated Largely based on code generated by an AI or LLM labels Apr 30, 2026

amarziali reviewed Apr 30, 2026

View reviewed changes

amarziali approved these changes Apr 30, 2026

View reviewed changes

sarahchen6 approved these changes Apr 30, 2026

View reviewed changes

Base automatically changed from mtoff/otlp-writer to master April 30, 2026 15:51

gh-worker-dd-mergequeue-cf854d Bot requested a review from a team as a code owner April 30, 2026 15:51

gh-worker-dd-mergequeue-cf854d Bot requested review from mcculls and removed request for a team April 30, 2026 15:51

Merge branch 'master' into mtoff/junit-otlp-test

84687be

mcculls approved these changes Apr 30, 2026

View reviewed changes

mtoffl01 and others added 2 commits April 30, 2026 13:32

Merge branch 'master' into mtoff/junit-otlp-test

ab734cb

remove old groovy file

971d907

mtoffl01 enabled auto-merge April 30, 2026 17:35

mtoffl01 added this pull request to the merge queue Apr 30, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 0fc1695 into master Apr 30, 2026
569 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the mtoff/junit-otlp-test branch April 30, 2026 19:30

github-actions Bot added this to the 1.62.0 milestone Apr 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate OtlpWriterCombinedTest from groovy to junit#11245

Migrate OtlpWriterCombinedTest from groovy to junit#11245
gh-worker-dd-mergequeue-cf854d[bot] merged 23 commits intomasterfrom
mtoff/junit-otlp-test

mtoffl01 commented Apr 30, 2026

Uh oh!

amarziali Apr 30, 2026

Uh oh!

mtoffl01 Apr 30, 2026

Uh oh!

amarziali left a comment

Uh oh!

sarahchen6 left a comment •

edited

Loading

Uh oh!

pr-commenter Bot commented Apr 30, 2026

Uh oh!

mcculls commented Apr 30, 2026

Uh oh!

mcculls left a comment

Uh oh!

dd-octo-sts Bot commented Apr 30, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mtoffl01 commented Apr 30, 2026

Motivation

Additional Notes

Contributor Checklist

Uh oh!

amarziali Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

mtoffl01 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

sarahchen6 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pr-commenter Bot commented Apr 30, 2026

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

mcculls commented Apr 30, 2026

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

dd-octo-sts Bot commented Apr 30, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sarahchen6 left a comment •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Apr 30, 2026 •

edited

Loading