Support sending OpenTelemetry logs over OTLP (http/protobuf)#11253
Support sending OpenTelemetry logs over OTLP (http/protobuf)#11253gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48a6076f65
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
Overall, it looks good to me.
I've added a few performance suggestions both my own and from Claude.
I don't feel strongly that any of them must be addressed before this is merged.
mcculls
force-pushed
the
mcculls/otlp-logs-proto
branch
from
890ebfa to
a28ffd6
Compare
…nd are eligible for UTF8 caching
mcculls
force-pushed
the
mcculls/otlp-logs-proto
branch
from
a28ffd6 to
8cacef8
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
2 participants
Additional Notes
Builds on top of #11250
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.