Correctly export overflow histogram bucket over OTLP#11261
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom May 4, 2026
Merged
Correctly export overflow histogram bucket over OTLP#11261gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
… for non-empty histograms
mcculls
changed the title
amarziali
approved these changes
May 4, 2026
PerfectSlayer
approved these changes
May 4, 2026
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status in_progress |
gh-worker-dd-mergequeue-cf854d
Bot
merged commit ba9194e
into
master
575 of 578 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
mcculls/fix-otlp-compact-histograms
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
According to metrics.proto
What Does This Do
When exporting compact OTLP histograms we should omit the overflow bucket boundary of +Infinity, but still export the counts for that bucket. If the overflow bucket is missing from DDSketch (because it had no counts) then we should export a count of zero for it.
This guarantees the expected behaviour that
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.