Skip to content

Enable publishing process context by default #11288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
May 6, 2026
Merged

Enable publishing process context by default #11288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions ...a-agent/agent-profiling/src/test/java/com/datadog/profiling/agent/ProcessContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.datadog.profiling.agent;

import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.mockStatic;
Expand Down Expand Up @@ -79,24 +80,8 @@ void testRegisterSkipsWhenDisabled() {
}

@Test
void testRegisterSkipsByDefault() {
ConfigProvider configProvider = mock(ConfigProvider.class);
when(configProvider.getBoolean(
eq(ProfilingConfig.PROFILING_PROCESS_CONTEXT_ENABLED),
eq(ProfilingConfig.PROFILING_PROCESS_CONTEXT_ENABLED_DEFAULT)))
.thenReturn(ProfilingConfig.PROFILING_PROCESS_CONTEXT_ENABLED_DEFAULT);

DdprofLibraryLoader.OTelContextHolder holder =
mock(DdprofLibraryLoader.OTelContextHolder.class);

try (MockedStatic<DdprofLibraryLoader> ddprofMock = mockStatic(DdprofLibraryLoader.class)) {
ddprofMock.when(DdprofLibraryLoader::otelContext).thenReturn(holder);

ProcessContext.register(configProvider);

verify(holder, org.mockito.Mockito.never()).getReasonNotLoaded();
verify(holder, org.mockito.Mockito.never()).getComponent();
}
void testEnabledByDefault() {
assertTrue(ProfilingConfig.PROFILING_PROCESS_CONTEXT_ENABLED_DEFAULT);
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion dd-trace-api/src/main/java/datadog/trace/api/config/ProfilingConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public final class ProfilingConfig {

public static final String PROFILING_PROCESS_CONTEXT_ENABLED =
"profiling.experimental.process_context.enabled";
public static final boolean PROFILING_PROCESS_CONTEXT_ENABLED_DEFAULT = false;
public static final boolean PROFILING_PROCESS_CONTEXT_ENABLED_DEFAULT = true;

public static final String PROFILING_DATADOG_PROFILER_LOG_LEVEL = "profiling.ddprof.loglevel";

Expand Down