Tolerate AbstractMethodError for servletRequest remote port#11403
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 18, 2026
Conversation
mcculls
approved these changes
May 18, 2026
Contributor
mcculls
left a comment
There was a problem hiding this comment.
Approving as speculative fix, which we'll check by seeing if telemetry changes
Contributor
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
198a35d
into
master
574 of 577 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
We have telemetry signals like this:
While this decorator works with a servlet 3 that would have bundled this method (
getRemotePortis available from servlet 2.4 onward) it looks like some underlying request objects have not implemented it.Muzzle should prevent linkage issues with the loaded runtime because (references):
Now what can happen (but we cannot prove it) is that the underlying application is wrapping the request with a
ServletRequestWrapperthat's been compiled against an older servlet version. In this case, when the JVM do theinvokeInterfaceit may hits theAbstractMethodErrorbecause not present in the bytecode.This PR ensure that the error is properly ignored and that the full advice is not interrupted because of this.
Hence we do not surface the error in the telemetry since now it's handled (but we log in debug in case)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.