Skip to content

Route Tomcat archive through MASS#11525

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/apmlp-1406-mass-tomcat
Jun 4, 2026
Merged

Route Tomcat archive through MASS#11525
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/apmlp-1406-mass-tomcat

Conversation

@bric3
Copy link
Copy Markdown
Contributor

@bric3 bric3 commented Jun 2, 2026

What Does This Do

When MASS_READ_URL is present, the Spring Boot Tomcat nested application resolves the Tomcat ZIP through MASS at /internal/artifact/dlcdn.apache.org. Without that environment variable, local builds keep using https://dlcdn.apache.org.

Motivation

CI should send build-time archive downloads through MASS when the upstream host is already allowed. The Tomcat archive host is covered by the existing .apache.org:443 suffix entry.

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines.
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels.
  • Avoid using linking keywords when referencing an issue.
  • Update CODEOWNERS on source file addition, migration, or deletion. Not applicable.
  • Update public documentation with any new configuration flags or behaviors. Not applicable.

Jira ticket: APMLP-1406, APMLP-1402

@bric3 bric3 added comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements labels Jun 2, 2026
@datadog-datadog-prod-us1

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left minor question.

Comment thread dd-smoke-tests/springboot-tomcat/application/build.gradle
@bric3 bric3 marked this pull request as ready for review June 2, 2026 14:27
@bric3 bric3 requested a review from a team as a code owner June 2, 2026 14:27
@bric3 bric3 requested review from ValentinZakharov and removed request for a team June 2, 2026 14:27
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 4, 2026

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 14.09 s [-2.0%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 13.06 s [-2.2%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 16.57 s 16.30 s [+0.5%; +2.8%] (maybe worse)
startup:petclinic:iast:Agent 16.63 s 16.58 s [-0.7%; +1.3%] (no difference)
startup:petclinic:profiling:Agent 16.36 s 16.68 s [-3.3%; -0.5%] (maybe better)
startup:petclinic:tracing:Agent 15.92 s 15.80 s [-0.4%; +2.0%] (no difference)

Commit: 17d7aff4 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
Copy link
Copy Markdown
Contributor Author

bric3 commented Jun 4, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jun 4, 2026

View all feedbacks in Devflow UI.

2026-06-04 17:10:34 UTC ℹ️ Start processing command /merge


2026-06-04 17:10:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-04 19:01:39 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit a4e1458 into master Jun 4, 2026
571 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/apmlp-1406-mass-tomcat branch June 4, 2026 19:01
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants