Route CICS SDK archive through MASS#11526
Conversation
bric3
added
inst: others
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3143fe40e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def massArtifactUrl = { String upstreamArtifactUrl -> | ||
| def massReadUrl = providers.environmentVariable('MASS_READ_URL').orNull | ||
| if (massReadUrl == null) { |
There was a problem hiding this comment.
If a CI job or local shell exports MASS_READ_URL as an empty or whitespace-only value, orNull still returns that value and this helper routes the Ivy repository to /internal/artifact/public.dhe.ibm.com/... instead of falling back to the IBM URL. That makes CICS SDK resolution fail in environments where the variable is defined but intentionally empty; the other MASS helpers in this repo guard this by trimming and treating blank values as absent.
Useful? React with 👍 / 👎.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
AlexeyKuznetsov-DD
left a comment
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM, hope to see that MASS dance moved to common place at some point.
3 participants
What Does This Do
When
MASS_READ_URLis present, the CICS 9.1 instrumentation resolves the IBM CICS SDK archive through MASS at/internal/artifact/public.dhe.ibm.com/software/htp/cics/support/supportpacs/individual/. Without that environment variable, local builds keep using the original IBM URL.Motivation
CI should send this build-time SDK archive through MASS once the IBM host is allowed. That keeps the dependency path explicit while preserving the upstream fallback for local builds.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labels.Jira ticket: APMLP-1407, [APMLP-1402]