Skip to content

Tolerate servlet 2.x wrappers used on servlet-3 classpath for isAsyncStarted calls#11542

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/servlet-asyncstarted
Jun 3, 2026
Merged

Tolerate servlet 2.x wrappers used on servlet-3 classpath for isAsyncStarted calls#11542
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/servlet-asyncstarted

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

What Does This Do

When servlet 2.x wrappers are used along with a servlet3 classpath the issue is that those wrappers are not implementing methods that are expected to be there by the servlet 3 spec.

One example is isAsyncStarted. In those cases we see issues like:

java.lang.AbstractMethodError
  at javax.servlet.ServletRequestWrapper.isAsyncStarted(ServletRequestWrapper.java:479)
  at javax.servlet.ServletRequestWrapper.isAsyncStarted(ServletRequestWrapper.java:479)
  at (redacted: 18 frames)

or even:

java.lang.AbstractMethodError
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
  at (redacted: 14 frames)

This PR makes sure that access to this method tolerates this case

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner June 3, 2026 08:57
@amarziali amarziali requested review from jordan-wong and removed request for a team June 3, 2026 08:57
@amarziali amarziali added type: bug Bug report and fix inst:servlet Servlet instrumentation tag: telemetry error reported Reported by error telemetry labels Jun 3, 2026
@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented Jun 3, 2026

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 5 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-java | java-startup-parallel-check-slo-breaches   View in Datadog   GitLab

See error No Markdown threshold comparison report generated by benchmark_analyzer due to missing scenarios for comparison.

DataDog/apm-reliability/dd-trace-java | java-startup-parallel-generate-slos   View in Datadog   GitLab

See error Artifact generation failed: directory 'artifacts' not found.

DataDog/apm-reliability/dd-trace-java | java-startup-parallel-upload-to-bp-api   View in Datadog   GitLab

See error File not found: '/go/src/github.com/DataDog/apm-reliability/dd-trace-java/artifacts/candidate-*.converted.json'.

View all 5 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d6c334b | Docs | Datadog PR Page | Give us feedback!

@amarziali
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jun 3, 2026

View all feedbacks in Devflow UI.

2026-06-03 14:33:32 UTC ℹ️ Start processing command /merge


2026-06-03 14:33:38 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-03 15:55:40 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 951d9a7 into master Jun 3, 2026
758 of 768 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/servlet-asyncstarted branch June 3, 2026 15:55
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst:servlet Servlet instrumentation tag: telemetry error reported Reported by error telemetry type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants