Extend W3CTraceParentTest coverage and migrate it to Java#11791
Conversation
🟡 Java Benchmark SLOs — Performance SLO warning (near threshold)
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
bric3
left a comment
There was a problem hiding this comment.
Thanks for the groovy test conversion
| assertEquals(expected, W3CTraceParent.from(traceId, spanId, isSampled)); | ||
| } | ||
|
|
||
| static Stream<Arguments> buildProducesCorrectFormatArguments() { |
There was a problem hiding this comment.
quibble: Maybe this can be replaced by a TableTest.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
8d8ce8d
into
master
Motivation
Meet expected test coverage.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]