Remove Jackson from dd-trace-ot#1185
Merged
Merged
Conversation
tylerbenson
force-pushed
the
tyler/remove-jackson
branch
2 times, most recently
from
c3404ea to
af212af
Compare
dougqh
reviewed
Jan 23, 2020
| writeByte(key, value.byteValue(), destination); | ||
| } else if (value instanceof Short) { | ||
| writeShort(key, value.shortValue(), destination); | ||
| } |
Contributor
There was a problem hiding this comment.
else with an exception for unsupported types?
dougqh
reviewed
Jan 23, 2020
Contributor
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
It looks things worked out nicely msgpack and Moshi.
I think it would be good to check our stats before merging this.
For the simple MemCheck app, I'd like to know...
- the number of classes loaded without this change & with this change
- the amount of metaspace consumed without change & with this change
Reduced the size of dd-java-agent jar by about 2 MB. Jackson is not removed completely though as it is still a dependency of jmxfetch. Trace serialization is primarily done directly with msgpack. Response deserialization and LoggingWriter serialization is done with mochi. Msgpack Serialization buffer still not being reused though.
tylerbenson
force-pushed
the
tyler/remove-jackson
branch
from
af212af to
697d497
Compare
Contributor
Author
|
Here are my test results: @dougqh Do you think that looks good enough? |
Contributor
Yes, that's actually a bit better than I expected. I was expecting ~300 classes & 2-3MiB from my prior analysis. Looks like we saved 400+ classes and 3.4MiB. Nice! |
dougqh
approved these changes
Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced the size of dd-java-agent jar by about 2 MB. Jackson is not removed completely though as it is still a dependency of jmxfetch.
Trace serialization is primarily done directly with msgpack.
Response deserialization and LoggingWriter serialization is done with mochi.
Msgpack Serialization buffer still not being reused though.
(PR based off of #1161... that should be merged first. So focus on the last commit.)