Add support for Spring Scheduling#1192
Merged
Merged
Conversation
tylerbenson
changed the title
tylerbenson
suggested changes
Jan 27, 2020
heathkd
force-pushed
the
heather.dsouza/scheduling_annotation
branch
3 times, most recently
from
931ac63 to
ffc57fb
Compare
tylerbenson
reviewed
Feb 4, 2020
Contributor
There was a problem hiding this comment.
Do you know why 3.2.4 is the earliest release this works with?
Contributor
Author
There was a problem hiding this comment.
Right so after investigating a bit further I found out the following:
- 3.1.0: works according to muzzle, but the Runnable is not wrapped and consequently the instrumentation is not applied
- 3.1.1 - 3.2.3: did not work
- 3.2.3: unit tests run, but some CI tests failed (from what I remember)
I retested 3.2.3 just now and it actually seems to be working, so I might try playing around with the version numbers again to confirm that 3.2.4 is the earliest working release.
heathkd
force-pushed
the
heather.dsouza/scheduling_annotation
branch
3 times, most recently
from
fa38890 to
ee31d33
Compare
tylerbenson
approved these changes
Feb 7, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
A few small changes then I think we're good. Consider squashing your commits before merging.
heathkd
force-pushed
the
heather.dsouza/scheduling_annotation
branch
2 times, most recently
from
39dbee7 to
3de452b
Compare
…ersion of spring-context
heathkd
force-pushed
the
heather.dsouza/scheduling_annotation
branch
from
3de452b to
917deb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These additions provide instrumentation for the Spring scheduling annotation. These changes will generate a trace for the annotated method.