Fixes orphaned spans from the lettuce reactor client#1203
Closed
devinsba wants to merge 27 commits into
Closed
Conversation
added 20 commits
February 14, 2020 09:42
…n a real app. It wouldn't have a function wrapping a flow like that
devinsba
force-pushed
the
devinsba/netty-reactor-lettuce-orphans
branch
from
9c6128d to
06f5081
Compare
added 2 commits
February 14, 2020 10:29
devinsba
commented
Feb 14, 2020
Comment on lines
+16
to
21
| pass { | ||
| group = "io.projectreactor.ipc" | ||
| module = "reactor-netty" | ||
| versions = "[0.7.0.RELEASE,)" | ||
| extraDependency "org.springframework:spring-webflux:5.0.0.RELEASE" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Looks like this will break on reactor-netty 1.0. Should I put an upper bound on this now?
| "$Tags.HTTP_STATUS" 500 | ||
| // Because of the way reactor has been instrumented to propagate errors we end up tagging this | ||
| // on both spans | ||
| errorTags(RuntimeException, "bad things happen") |
| callback?.call() | ||
| // The callback span is expected to be detached from the client trace, this however means we either have | ||
| // to have the reactor instrumentation not work in this case, breaking the lettuce flow expectations, or | ||
| // we can make this code conditional here to make the test pass |
Contributor
Author
There was a problem hiding this comment.
Maybe I should change the parent test class to make this conditional?
devinsba
commented
Feb 14, 2020
Comment on lines
+28
to
+29
| Hooks.onEachOperator(ReactorHooksAdvice.tracingOperator()) | ||
| Hooks.onLastOperator(ReactorHooksAdvice.tracingOperator()) |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why but the reactor instrumentation isn't automatically applying even though the dependency is there...
devinsba
commented
Feb 14, 2020
Contributor
Author
|
Closing to manually rebase in #1308 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spans were being lost when scoping in reactor, this approach uses hooks to wrap most of the operators