Reduce use of Thread::setContextClassLoader and hard references to DatadogClassLoader#1204
Merged
lpriima merged 1 commit intoFeb 7, 2020
Merged
Conversation
lpriima
force-pushed
the
lpriima/reduce_use_of_Thread#setContextClassLoader
branch
from
9b77446 to
5265a43
Compare
dougqh
reviewed
Feb 7, 2020
| * Editor > Code Style > Java/Groovy > Imports | ||
| * Class count to use import with '*': `50` (some number sufficiently large that is unlikely to matter) | ||
| * Names count to use static import with '*': `50` | ||
| * Class count to use import with '*': `9999` (some number sufficiently large that is unlikely to matter) |
dougqh
reviewed
Feb 7, 2020
Contributor
dougqh
left a comment
dougqh
left a comment
There was a problem hiding this comment.
I think the change looks good, but I would like someone a little more familiar with the core to confirm.
tylerbenson
approved these changes
Feb 7, 2020
lpriima
deleted the
lpriima/reduce_use_of_Thread#setContextClassLoader
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify explicit AgentInstaller class loader instead of storing reference to context class loader in current thread object. We can install agent by ServiceLoader::load(Class, ClassLoader) and without this call
https://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/file/70e3553d9d6e/src/share/classes/java/util/ServiceLoader.java#l498