Split interface and class "supertype matching"#1232
Merged
Conversation
randomanderson
force-pushed
the
landerson/supertype-matcher-improvement
branch
from
1b5875f to
43487fc
Compare
devinsba
approved these changes
Feb 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits
safeHasSuperType()intosafeExtendsClass()andsafeHasInterface()and narrows the matching for almost all instrumentations (The ones that still usesafeHasSuperType()areFieldBackedProvider,JaxRs,Servlet, andTraceAnnotations)There doesn't seem to be any affect on startup time but I think the changes might allow better specialization in the future.