Merge pull request #1240 from DataDog/tyler/executor-matcher-reorder#1240
Merged
Conversation
Move the expensive matcher to last. In theory this should help, but did not seem to make a significant difference in basic startup benchmarks.
dougqh
reviewed
Feb 21, 2020
| new ElementMatcher<TypeDescription>() { | ||
| @Override | ||
| public boolean matches(final TypeDescription target) { | ||
| boolean whitelisted = WHITELISTED_EXECUTORS.contains(target.getName()); |
Contributor
There was a problem hiding this comment.
We might get a bit more from turning this into a string switch, but I suspect we've probably reached a point of diminishing returns.
Contributor
Author
There was a problem hiding this comment.
Let's consider that in the future.
dougqh
approved these changes
Feb 21, 2020
tylerbenson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the expensive matcher to last.
In theory this should help, but did not seem to make a significant difference in basic startup benchmarks.