Skip to content

Add additional ignores#1282

Merged
mar-kolya merged 25 commits into
masterfrom
mar-kolya/add-additional-ignores
Mar 4, 2020
Merged

Add additional ignores#1282
mar-kolya merged 25 commits into
masterfrom
mar-kolya/add-additional-ignores

Conversation

@mar-kolya
Copy link
Copy Markdown
Contributor

@mar-kolya mar-kolya commented Mar 3, 2020

This seems to be improving pet clinic startup by ~3 seconds.

@mar-kolya mar-kolya force-pushed the mar-kolya/add-additional-ignores branch from 181e29c to 8573dac Compare March 3, 2020 13:01
@mar-kolya mar-kolya changed the title Sdd additional ignores Add additional ignores Mar 3, 2020
@mar-kolya mar-kolya force-pushed the mar-kolya/add-additional-ignores branch 2 times, most recently from add58a1 to e5418fe Compare March 3, 2020 16:17
@mar-kolya mar-kolya force-pushed the mar-kolya/add-additional-ignores branch 3 times, most recently from ccc74a2 to ea19db2 Compare March 3, 2020 18:16
@trask
Copy link
Copy Markdown
Contributor

trask commented Mar 3, 2020

Hi @mar-kolya! How are you checking these packages for Runnable or Callable classes that may need to be instrumented?

Also, curious if there's been discussion already about how to decide which libraries (out of the thousands of millions of Java libraries 😆) to include in the ignore list. Thanks!

@mar-kolya mar-kolya force-pushed the mar-kolya/add-additional-ignores branch 4 times, most recently from 46e9a24 to 7d8e3be Compare March 3, 2020 19:29
@mar-kolya mar-kolya force-pushed the mar-kolya/add-additional-ignores branch 2 times, most recently from f91ca65 to 729c4e4 Compare March 3, 2020 19:48
@mar-kolya mar-kolya force-pushed the mar-kolya/add-additional-ignores branch from 729c4e4 to a62db5b Compare March 3, 2020 19:51
@mar-kolya mar-kolya requested a review from a team March 3, 2020 20:13
@mar-kolya mar-kolya marked this pull request as ready for review March 3, 2020 20:18
@mar-kolya
Copy link
Copy Markdown
Contributor Author

mar-kolya commented Mar 3, 2020

Hi @mar-kolya! How are you checking these packages for Runnable or Callable classes that may need to be instrumented?

We now have a test that essentially disables this library matcher - and makes sure that no classes are modified that would have been excluded by this matcher. So since all tests pass this means we didn't try to modify excluded classes in our tests.

Also, curious if there's been discussion already about how to decide which libraries (out of the thousands of millions of Java libraries 😆) to include in the ignore list. Thanks!

There was no specific discussion, purely subjective choice - mainly based on what libraries we pull to run tracer's tests

@trask
Copy link
Copy Markdown
Contributor

trask commented Mar 3, 2020

We now have a test that essentially disables this library matcher - and makes sure that now classes are modified that would have been excluded by this matcher. So since all tests pass this means we didn't try to modify excluded classes in our tests.

Nice!

There was no specific discussion, purely subjective choice - mainly based on what libraries we pull to run tracer's tests

Makes sense, thx for your responses!

@mar-kolya mar-kolya merged commit 11f281e into master Mar 4, 2020
@mar-kolya mar-kolya deleted the mar-kolya/add-additional-ignores branch March 4, 2020 02:43
@tylerbenson tylerbenson added this to the 0.45.0 milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants