Fix Play-ws stream() bug#1286
Merged
Merged
Conversation
tylerbenson
approved these changes
Mar 3, 2020
Contributor
Author
@tylerbenson It was a lot more straightforward before the refactor but the amount of copy/pasting was killing me. It probably should have been 2 separate PRs |
3e51ecc to
d6638f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the play-ws instrumentation where calls to
.stream()lead to a separate wrapper class being needed (#1252 ). Requiring these lines be added:Additionally, this pull request:
Adds a chunked encoding test to theHttpClientTestUnfortunately, the tests also exposed a bug in the play-ws and/or scala promises instrumentation where callbacks to a promise aren't executed in the correct context. I added a flag to that
HttpClientTestalong with a//FIXMEcomment