ClassLoader matcher cleanup#1298
Merged
Merged
Conversation
randomanderson
requested changes
Mar 5, 2020
Contributor
randomanderson
left a comment
randomanderson
left a comment
There was a problem hiding this comment.
Much cleaner 👍 . I think in one file you missed an inverted statement.
randomanderson
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove double negative and add additional matchers.
Also add limit to number of elements in the cache.
Follow up from #1283
TODO: combine into a single cache to reduce number of different caches.