Move common helper classes to bootstrap#1311
Merged
Merged
Conversation
tylerbenson
approved these changes
Mar 11, 2020
tylerbenson
approved these changes
Mar 11, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Once tests are passing...
tylerbenson
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the java-concurrent helper classes and base decorator classes to the bootstrap project. It removes a lot of repetition in instrumenters, gives minimal startup gains (less HelperInjector calls), and moves dd-java-agent closer to running on read only operating systems. #429
After this pull request, I believe the only classes we still inject on the bootstrap are
FieldBackedProviderhelper classes, the helper classes forJDBC, and the helper classes forHttpUrlConnectionLots of changed files because this touches everything but almost all are changes to imports or
helperClassNames[]