Remove hostname and port from HttpClientDecorator#1316
Merged
Conversation
Contributor
Author
|
I don't know much of groovy, so I'm just gonna make random changes until it works. lmk if I'm on the wrong track |
Contributor
Author
|
First try! ;) |
Contributor
Author
|
woe is me... |
tylerbenson
suggested changes
Mar 13, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Two small changes requested, then we can figure out the build errors.
Thanks for the PR!
tylerbenson
approved these changes
Mar 13, 2020
Contributor
|
The java 7 failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was talking to @tylerbenson and saw that our traces were doing a lot of parsing of URIs. I've found the culprit to be in the
hostname(REQUEST request)andport(REQUEST request)methods. Since this data is already computed via the initial URI parse to build the url, I see no need to delegate the extra calls for tags.