Fix Extractor edge case with value of a single comma.#1356
Merged
Conversation
Turns out the issue wasn't with an empty string returning an empty array, but a string with just `,`.
```
jshell> ",".split(",")
$1 ==> String[0] { }
```
A non-intuitive edge case in my opinion.
tylerbenson
changed the title
tylerbenson
commented
Apr 7, 2020
Comment on lines
+306
to
+308
| if (split.length > 0) { | ||
| value = split[0].trim(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The else case here means that value will be left simply as ,. Should it be explicitly set to null or empty string instead?
Merged
Contributor
|
Yes, I find that behavior of split surprising as well. This change looks good to me. My biggest concern is whether we have other calls to String.split that also need to be fixed. |
dougqh
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the issue wasn't with an empty string returning an empty array, but a string with just
,.A non-intuitive edge case in my opinion.