Extend JDBC catch to include Errors#1385
Merged
Merged
Conversation
Contributor
|
Do we want add a test for this case? |
This should help resolve a situation where `getClientInfo` is not implemented and throws an `AbstractMethodError`.
tylerbenson
force-pushed
the
tyler/extend-jdbc-catch
branch
from
cff791f to
a2156fd
Compare
devinsba
approved these changes
Apr 21, 2020
Contributor
devinsba
left a comment
devinsba
left a comment
There was a problem hiding this comment.
Works for me assuming testing this would be too time consuming
Contributor
Author
|
@devinsba I did modify the test to validate the change. (Before the test was just throwing |
Contributor
|
Yes, I think a simple test is the right choice for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help resolve a situation where
getClientInfois not implemented and throws anAbstractMethodError.