Rework servlet 2 to not wrap HttpServletResponse objects#1387
Merged
Conversation
devinsba
force-pushed
the
devinsba/dont-change-servletresponse-type
branch
2 times, most recently
from
9849dd7 to
88b9efe
Compare
Contributor
Author
|
This is the only failing due to the muzzle artifact resolution issue addressed in #1386 |
tylerbenson
previously requested changes
Apr 20, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Reasonable change, but I'm not keen on storing the response status on the request when we can instead just use it directly.
dougqh
reviewed
Apr 20, 2020
devinsba
force-pushed
the
devinsba/dont-change-servletresponse-type
branch
from
03c3fc0 to
aec2fad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some applications cast to their
HttpServletResponsetype without doing a type check for the wrapper type and unwrapping.