Rediscala instrumentation#1389
Merged
Merged
Conversation
tylerbenson
suggested changes
Apr 20, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Need to remove the duplicated code... otherwise 👍
Contributor
There was a problem hiding this comment.
do you know why 1.8.0 doesn't work?
Contributor
Author
There was a problem hiding this comment.
It looks like the instrumentation is built against a fork source code of etaty/rediscala. Let's catch up later to discuss which library we should be supporting.
richardstartin
force-pushed
the
rediscala-instrumentation
branch
from
26533a2 to
41c458e
Compare
tylerbenson
approved these changes
Apr 21, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Optional comment about adding muzzle check for the other library version.
tylerbenson
approved these changes
Apr 21, 2020
richardstartin
force-pushed
the
rediscala-instrumentation
branch
from
9209e24 to
dc84659
Compare
devinsba
reviewed
Apr 21, 2020
This was referenced Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases #1111 against latest API, and addresses comments on that PR.