Skip to content

Http Trace and Span ID should be StringCachingBigInteger #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylerbenson merged 1 commit into from
Apr 24, 2020
Merged

Http Trace and Span ID should be StringCachingBigInteger #1397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dd-trace-ot/src/main/java/datadog/opentracing/propagation/HttpCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import datadog.opentracing.DDSpanContext;
import datadog.opentracing.DDTracer;
import datadog.opentracing.StringCachingBigInteger;
import datadog.trace.api.Config;
import io.opentracing.SpanContext;
import io.opentracing.propagation.TextMapExtract;
Expand Down Expand Up @@ -117,7 +118,7 @@ public SpanContext extract(final TextMapExtract carrier) {
*/
static BigInteger validateUInt64BitsID(final String value, final int radix)
throws IllegalArgumentException {
final BigInteger parsedValue = new BigInteger(value, radix);
final BigInteger parsedValue = new StringCachingBigInteger(value, radix);
if (parsedValue.compareTo(DDTracer.TRACE_ID_MIN) < 0
|| parsedValue.compareTo(DDTracer.TRACE_ID_MAX) > 0) {
throw new IllegalArgumentException(
Expand Down