Provide instrumentation support for lettuce-4.0-4.5.0 sync/async APIs#1398
Merged
Conversation
richardstartin
force-pushed
the
richardstartin/lettuce-4.0
branch
2 times, most recently
from
53d0832 to
94f56b4
Compare
tylerbenson
reviewed
Apr 24, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
A few quick comments... I'll give it a further review next week.
devinsba
reviewed
Apr 24, 2020
richardstartin
force-pushed
the
richardstartin/lettuce-4.0
branch
from
149aeca to
925679c
Compare
richardstartin
force-pushed
the
richardstartin/lettuce-4.0
branch
from
925679c to
d158590
Compare
tylerbenson
approved these changes
Apr 27, 2020
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Please update the PR title and description (what would a consumer of this integration find useful to know?)
Optional comments below...
|
|
||
| import static datadog.trace.instrumentation.lettuce.InstrumentationPoints.AGENT_CRASHING_COMMAND_PREFIX | ||
|
|
||
| class LettuceAsyncClientTest extends AgentTestRunner { |
Contributor
There was a problem hiding this comment.
Is there any logic that can be shared between the sync/async tests?
| // Workaround to keep trace agent from crashing | ||
| // Currently the commands in AGENT_CRASHING_COMMANDS_WORDS will crash the trace agent and | ||
| // traces with these commands as the resource name will not be processed by the trace agent | ||
| // https://github.com/DataDog/datadog-trace-agent/blob/master/quantizer/redis.go#L18 has |
Contributor
There was a problem hiding this comment.
This url is now out of date... maybe find the new one?
Contributor
Author
There was a problem hiding this comment.
I looked for it, but couldn't find it, there seems to have been major refactoring here.
Contributor
Author
There was a problem hiding this comment.
I have removed the link but will follow up to see if this logic can actually just be removed in another PR.
Contributor
There was a problem hiding this comment.
richardstartin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.