Upgrade Byte Buddy to 1.10.10#1409
Merged
Merged
Conversation
Contributor
|
In the past, we've some jumps in memory overhead when upgrading bytebuddy. I'd like to have a breakdown of old gen & metaspace before and after the upgrade. |
tylerbenson
force-pushed
the
tyler/upgrade-bytebuddy
branch
from
7330ad6 to
3fed582
Compare
Contributor
Author
|
@dougqh it actually seems like an improvement... Spring Petclinic, Java 8, After startup No Javaagent: Master: Byte Buddy Upgrade: |
Contributor
|
Yes, old gen & metaspace look good. Hard to tell if young gen is higher with cycle info, but old gen & metaspace are the main concerns. I'm fine with this as is. Then we'll have to watch the internal perf tests to make certain. |
dougqh
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.