Change logging for ScopeEventFactory creation exception#1417
Merged
Conversation
tylerbenson
approved these changes
Apr 30, 2020
mar-kolya
reviewed
May 1, 2020
| Class.forName("datadog.trace.core.jfr.openjdk.ScopeEventFactory").newInstance(); | ||
| } catch (final ClassFormatError | ReflectiveOperationException | NoClassDefFoundError e) { | ||
| log.debug("Cannot create Openjdk JFR scope event factory", e); | ||
| log.debug("Profiling ScopeEvents is disabled"); |
Contributor
There was a problem hiding this comment.
Nit: It seems to me that disabled would imply some deliberate uses action. Profiling ScopeEvents are not available?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1345 and similar to #1395
The
datadog.trace.core.jfr.openjdk.ScopeEventFactoryclass not being available happens in multiple common cases:jfr-openjdkdependencyLogging the exception creates the mistaken impression of an error and creates a lot of spam in the test logs.