Do not stop profiling on fatal exceptions#1421
Merged
mar-kolya merged 2 commits intoMay 4, 2020
Merged
Conversation
jbachorik
reviewed
May 4, 2020
| throw t; | ||
| /* | ||
| Try to continue even after fatal exception. It seems to be useful to attempt to store profile when this happens. | ||
| For example JVM maybe out of heap and throwing OutOfMemoryError - we probably still would want to continue and |
Contributor
There was a problem hiding this comment.
For OOME usually it is not really good to try and and log exception - the memory is stretched already and the logging statement can throw its own OOME and propagate the exception we are trying to mask to the caller.
I would suggest handling OOME differently and just silently ignore it.
Contributor
Author
There was a problem hiding this comment.
good point, I'll just wrap the whole logging statement in try/catch
Contributor
There was a problem hiding this comment.
Good idea to try the log if possible!
jbachorik
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that profiling continues to run even after fatal exceptions in its loop - e.g.
OutOfMemoryError