Fix cassandra instrumentation to use a daemon thread#1422
Merged
Conversation
| public class TracingSession implements Session { | ||
|
|
||
| private final ExecutorService executorService = Executors.newCachedThreadPool(); | ||
| private static final ExecutorService EXECUTOR_SERVICE = |
Contributor
There was a problem hiding this comment.
Do we want to shut this down when the application terminates?
Contributor
Author
There was a problem hiding this comment.
well, won't that happen automatically since the thread is daemon now?
Contributor
There was a problem hiding this comment.
OK, I was thinking of that as more of an insurance policy for some kind graceful shut down routine we would plug in to. Seems fine though.
richardstartin
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not prevent application shutdown.