Minor ScopeManager cleanup#1462
Merged
Merged
Conversation
tylerbenson
force-pushed
the
tyler/remove-simplescope
branch
from
f4f3f3c to
16936cd
Compare
richardstartin
previously requested changes
May 15, 2020
Contributor
richardstartin
left a comment
richardstartin
left a comment
There was a problem hiding this comment.
this escapes in Continuation which is a dangerous practice in multithreaded settings.
tylerbenson
dismissed
richardstartin’s stale review
I think escaping of instances out of the constructor is something that should be dealt with, but let's handle it in a separate PR as it seems independent from the changes here.
Contributor
Author
|
@richardstartin the change you suggested was smaller than I though, so I went ahead and made the change here. Sorry about that. |
richardstartin
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to do more, but was limited by the fact that we allow access to the current scope.