allow user to disable kafka time in queue tag#1487
Merged
Conversation
bantonsson
approved these changes
May 22, 2020
lpriima
approved these changes
May 22, 2020
Contributor
|
What would you consider an "old" client in this sense? It doesn't make sense to me that this would break things on the clients we currently support. |
Contributor
Author
|
So the problem is if the timestamp is not |
richardstartin
force-pushed
the
richardstartin/disable-kafka-timestamp
branch
from
49157c2 to
2a04e73
Compare
tylerbenson
approved these changes
May 26, 2020
iNikem
pushed a commit
to open-telemetry/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 2, 2020
* Add time in queue (DataDog/dd-trace-java#1481) * Minor upgrades (DataDog/dd-trace-java#1495) * Allow user to disable kafka time in queue tag (DataDog/dd-trace-java#1487) * Replace Set<Integer> with BitSet for HTTP statuses (DataDog/dd-trace-java#1496) * Register WeakMapProvider earlier in AgentInstaller (DataDog/dd-trace-java#1480) * Update codenarc (DataDog/dd-trace-java#1500) Co-authored-by: Tyler Benson <tyler.benson@datadoghq.com> Co-authored-by: Nikolay Martynov <mar.kolya@gmail.com> Co-authored-by: Richard Startin <richard.startin@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1448, #1481. Need to be able to avoid calling
ConsumerRecord.timestampwhen there are old kafka clients present.