Bootstrap delegation for wildfly/jboss#231
Conversation
realark
commented
Feb 14, 2018
realark
commented
- Set system property to tell jboss/wildfly to delegate to datadog bootstrap classes
realark
force-pushed
the
ark/fix_wildfly
branch
from
85b2cbb to
d54269c
Compare
There was a problem hiding this comment.
My initial suggestion was to have this in a "transform" block... Similar to what we do for injecting helper classes.
There was a problem hiding this comment.
I initially did that. Problem is, bytebuddy thinks transformers which return null have failed. This was causing us to log an error.
There was a problem hiding this comment.
I'd suggest using a StringBuilder with the existing value the start of the StringBuilder. This seems like a lot of unnecessary string concatenation.
There was a problem hiding this comment.
For code paths that are only hit once string concatenation isn't a big deal, but using a string builder is fine.
There was a problem hiding this comment.
Maybe a comment explaining what is significant about this class?
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Move code to transform and use string builder.
realark
force-pushed
the
ark/fix_wildfly
branch
from
d54269c to
fb2dd21
Compare
|
My comment was lost in the diff. Reposting. I initially used a transformer to set the property. Problem is, bytebuddy thinks transformers which return null have failed. This was causing us to log an error. It's harmless, but I think it would confuse support if they saw a failed transform error in the logs. |
realark
force-pushed
the
ark/fix_wildfly
branch
from
fb2dd21 to
14aaf82
Compare
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Looks good. Out of curiosity, any idea what versions of JBoss this is required for?
|
It seems to have been around for a while. The version I'm testing against goes back a few years (I had to use an old version to stay java 7 compatible). |
2 participants
