Use nanotime for additional clock resolution#239
Merged
Conversation
tylerbenson
added
type: enhancement
realark
approved these changes
Feb 22, 2018
Contributor
realark
left a comment
realark
left a comment
There was a problem hiding this comment.
Looks good to me.
I noticed we're not guarded against multiple threads calling finish. I believe that's okay, since we weren't doing it before. Just thought I'd point that out.
Contributor
Author
|
Good point... if that were to happen on the root span, is it possible the trace would be written to the queue twice? |
If a start or stop timestamp on a span is provided, the nanotime is ignored.
tylerbenson
force-pushed
the
tyler/nano-resolution
branch
from
f4fb903 to
4c66bc8
Compare
Contributor
Author
|
I think I'll address the threadsafety issue in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a start or stop timestamp on a span is provided, the nanotime is ignored.