Trap agent errors in DDTracingClientExec#258
Merged
Merged
Conversation
realark
added
tag: do not merge
tylerbenson
previously requested changes
Mar 12, 2018
Contributor
tylerbenson
left a comment
tylerbenson
left a comment
There was a problem hiding this comment.
Could you add some comments in the code explaining the change. It's not really clear why it was needed.
tylerbenson
reviewed
Mar 12, 2018
Contributor
There was a problem hiding this comment.
I assume networkSpan might be null here. Is that a problem?
realark
force-pushed
the
ark/httpclientwrapper_fix
branch
from
a5acfab to
c3c76c8
Compare
realark
dismissed
tylerbenson’s stale review
Added some comments and a null check when setting the status code.
tylerbenson
approved these changes
Mar 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our HTTPClient instrumentation inserts itself into the client's exec chain to create spans. This requires the instrumentation to re-throw exceptions, but the instrumentation was not capturing internal errors which should have been caught.
This change guards against internal agent exceptions being thrown into the client.