Clean up version logging and name start timestamp unit correctly#286
Conversation
| public static void logAllVersions() { | ||
| log.info( | ||
| "dd-trace-ot - version: {}", | ||
| getVersionString(Utils.getAgentClassLoader().getResourceAsStream("dd-trace-ot.version"))); |
There was a problem hiding this comment.
I originally separated this out to highlight if someone was using an incompatible version of dd-trace-ot or the api. I don't think that this new way of doing things accomplishes that, so if this is the way we need to do things, I'm ok with just removing the duplication.
There was a problem hiding this comment.
Our new javaagent bootstrap process breaks the original version verification because the only jars that will be on the agent's classpath must come from the jars embedded in the dd-java-agent.jar.
I left the original version checks in there for cases where the ot and api jars are run as the main app (where they print the version string). Do you think that's worth keeping or should we just remove that logic?
There was a problem hiding this comment.
Yeah. Good to have the version checking ability.
3 participants
@palazzem From our troubleshooting session earlier today.
It turns out we actually are expecting microseconds to
withStartTimestamp; the parameter name was misleading.