Skip to content

Enable executor instrumentation by default#295

Merged
realark merged 1 commit into
masterfrom
ark/enable_async_instrumentation
May 1, 2018
Merged

Enable executor instrumentation by default#295
realark merged 1 commit into
masterfrom
ark/enable_async_instrumentation

Conversation

@realark
Copy link
Copy Markdown
Contributor

@realark realark commented Apr 26, 2018

Executor instrumentation does not need to be turned off by default
because the instrumentation will not apply unless the TraceScope is
activated.

@realark realark added this to the 0.7.0 milestone Apr 26, 2018
@realark realark requested a review from tylerbenson April 26, 2018 22:50
@tylerbenson
Copy link
Copy Markdown
Contributor

Can you do a find/replace to remove:

System.setProperty("dd.integration.java_concurrent.enabled", "true")

@realark realark force-pushed the ark/enable_async_instrumentation branch from f55f854 to 1d490ad Compare April 27, 2018 16:29
@realark realark modified the milestones: 0.7.0, 0.8.0 Apr 27, 2018
@tylerbenson tylerbenson force-pushed the ark/enable_async_instrumentation branch from 1d490ad to c3f4022 Compare April 30, 2018 01:53
Executor instrumentation does not need to be turned off by default
because the instrumentation will not apply unless the TraceScope is
activated.
@realark realark force-pushed the ark/enable_async_instrumentation branch from c3f4022 to 3c7d4f5 Compare May 1, 2018 00:29
@realark realark merged commit 11ecff0 into master May 1, 2018
@realark realark deleted the ark/enable_async_instrumentation branch May 1, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants