Use different resource naming for aws spans#299
Merged
Conversation
tylerbenson
added
type: enhancement
tylerbenson
force-pushed
the
tyler/aws-naming
branch
2 times, most recently
from
fc1bf4f to
7dfef00
Compare
realark
reviewed
May 3, 2018
Contributor
There was a problem hiding this comment.
Is remapServiceName supposed to be called twice?
realark
approved these changes
May 3, 2018
Uses the pattern of `service.operation`, so for an S3 get object request, the resource name would be `S3.GetObject`.
tylerbenson
force-pushed
the
tyler/aws-naming
branch
from
7dfef00 to
82353ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the pattern of
service.operation, so for an S3 get object request, the resource name would beS3.GetObject.This changes the resource name, so existing metrics will change.