Fix NoClassDefFound errors for ratpack#301
Merged
tylerbenson merged 1 commit intoApr 30, 2018
Merged
Conversation
tylerbenson
approved these changes
Apr 30, 2018
Contributor
There was a problem hiding this comment.
These should be on the bootstrap classpath. Are you sure they’re needed here?
Contributor
Author
There was a problem hiding this comment.
Good point. I've reduced this to the smallest number of classes needed.
jonmort
force-pushed
the
ratpack-instrumentation-exceptions
branch
from
b0b6549 to
c1a7f58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #300 removing Google Collections runtime and adding all the necessary HelperInjector classes.
I have verified that this works in a real world Ratpack application (not just those in the integration tests)