Prevent JDBC spans from nesting#302
Conversation
tylerbenson
added
type: enhancement
tylerbenson
force-pushed
the
tyler/jdbc-depth
branch
from
53d2d40 to
6f64b0e
Compare
| } catch (final Throwable e) { | ||
| // Had some problem getting the connection. | ||
| return NoopScopeManager.NoopScope.INSTANCE; | ||
| return null; |
There was a problem hiding this comment.
I think this could be a bug if we hit this on the first execute (callDepth == 0); the depth count won't be reset in the exit.
There was a problem hiding this comment.
Additionally, what gets passed to @Advice.Enter if the instrumentation throws an exception? null?
There was a problem hiding this comment.
Good point about the call depth not getting reset. Do you have any ideas on how I could work around this?
(for your second question, I'm not sure...)
There was a problem hiding this comment.
What do you think about explicitly decrementing the call count in the exit? That way we'll always hit 0. That may require adding a new method to the call depth local map.
There was a problem hiding this comment.
I think switching back to a noop scope will work better. I'll just do that.
2 participants
No description provided.