Add tracing for other annotations and config#311
Merged
Conversation
tylerbenson
commented
May 4, 2018
| public AgentBuilder apply(final AgentBuilder agentBuilder) { | ||
| ElementMatcher.Junction<NamedElement> methodTraceMatcher = | ||
| is(new TypeDescription.ForLoadedType(Trace.class)); | ||
| for (final String annotationName : ADDITIONAL_ANNOTATIONS) { |
Contributor
Author
There was a problem hiding this comment.
Perhaps we want a config to allow disabling the additional annotations? Maybe instead a config to set your own list?
Contributor
There was a problem hiding this comment.
That's probably a good idea in case this causes unwanted traces to be created.
realark
suggested changes
May 5, 2018
Contributor
realark
left a comment
realark
left a comment
There was a problem hiding this comment.
Once there's a config to disable the list of additional traces (or specify a custom list) then I'm okay with merging.
tylerbenson
force-pushed
the
tyler/additional-trace-annotations
branch
from
35bdc4c to
fc6f4c2
Compare
tylerbenson
force-pushed
the
tyler/warnings
branch
from
930c785 to
c1ac920
Compare
Allows for specifying additional traced methods via env var or sys prop config.
List can be set to empty if needed.
tylerbenson
force-pushed
the
tyler/additional-trace-annotations
branch
from
7609892 to
c81615b
Compare
realark
approved these changes
May 7, 2018
tylerbenson
added a commit
that referenced
this pull request
May 8, 2018
Add tracing for other annotations and config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for specifying additional traced methods via env var or sys prop config.