Enable async tracking for some non-async frameworks#316
Merged
Conversation
This will allow tracing of additional work being done inside the servlet context.
Contributor
|
I think we'll also want to turn off the async propagation when the root span finishes. |
Contributor
Author
|
@realark I didn't worry about that because the async propagation flag is on the scope, which is recreated every request and goes away when that scope is closed. If we add the flag to turn it off, it kinda clutters the code. |
realark
approved these changes
May 10, 2018
Contributor
realark
left a comment
There was a problem hiding this comment.
👍 Good point, once the scope is closed the async propagation will finish so it's not required to turn it off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow tracing of additional work being done inside the servlet context.
Closes #304