Using single class-loader for internal agent classes and resources#3684
Merged
Conversation
6859bac to
a7212bc
Compare
…fined in same class-loader
…content indexed at build-time
…Sampling.canSampleExceptions)
a7212bc to
5b94dac
Compare
dougqh
approved these changes
Aug 10, 2022
jbachorik
approved these changes
Aug 11, 2022
bantonsson
approved these changes
Aug 11, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
ExceptionSamplersingleton at any time - assuming that if it was called too early, thestaticfinalmember would be temporarilynullwithout affecting creation later on (ie. no side-effect such as the JVM remembering and throwing a class initializer error)ExceptionSampleronce we know startup has reached a point where its dependencies are all ready