Skip to content

Using single class-loader for internal agent classes and resources#3684

Merged
mcculls merged 17 commits into
masterfrom
mcculls/simplifyInternalClassloading
Aug 14, 2022
Merged

Using single class-loader for internal agent classes and resources#3684
mcculls merged 17 commits into
masterfrom
mcculls/simplifyInternalClassloading

Conversation

@mcculls
Copy link
Copy Markdown
Contributor

@mcculls mcculls commented Jul 29, 2022

Notes:

  • the separate class-loaders were hiding a potential startup issue involving JFR and the throwable instrumentation
  • the previous assumption was it was always safe to try and create the ExceptionSampler singleton at any time - assuming that if it was called too early, the static final member would be temporarily null without affecting creation later on (ie. no side-effect such as the JVM remembering and throwing a class initializer error)
  • we now only 'unlock' access to the ExceptionSampler once we know startup has reached a point where its dependencies are all ready
  • some unused/unnecessary methods were removed
  • the internal JAR protocol was removed and replaced by a build-time generated index to the appropriate sub-module
  • some unnecessary indirection (leftover from before we added classes to the bootstrap class path) was removed

@mcculls mcculls added the tag: do not merge Do not merge changes label Jul 29, 2022
@mcculls mcculls force-pushed the mcculls/simplifyInternalClassloading branch 8 times, most recently from 6859bac to a7212bc Compare August 4, 2022 11:07
@mcculls mcculls added type: refactoring and removed tag: do not merge Do not merge changes labels Aug 4, 2022
@mcculls mcculls changed the title work-in-progress Using single class-loader for internal agent classes and resources Aug 4, 2022
@mcculls mcculls marked this pull request as ready for review August 4, 2022 11:41
@mcculls mcculls requested a review from a team as a code owner August 4, 2022 11:41
@mcculls mcculls force-pushed the mcculls/simplifyInternalClassloading branch from a7212bc to 5b94dac Compare August 10, 2022 16:21
@mcculls mcculls merged commit 556da4e into master Aug 14, 2022
@mcculls mcculls deleted the mcculls/simplifyInternalClassloading branch August 14, 2022 10:32
@github-actions github-actions Bot added this to the 0.107.0 milestone Aug 14, 2022
@mcculls mcculls restored the mcculls/simplifyInternalClassloading branch August 22, 2022 15:59
@mcculls mcculls deleted the mcculls/simplifyInternalClassloading branch August 22, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants