-
Notifications
You must be signed in to change notification settings - Fork 318
Call Site Instrumentation plugin #3729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
manuel-alvarez-alvarez
merged 1 commit into
master
from
malvarez/call-site-instrumentation-plugin
Oct 10, 2022
Merged
Call Site Instrumentation plugin #3729
manuel-alvarez-alvarez
merged 1 commit into
master
from
malvarez/call-site-instrumentation-plugin
Oct 10, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1164303 to
52dd96a
Compare
04f4e5a to
94c6fce
Compare
anderruiz
reviewed
Sep 7, 2022
buildSrc/src/main/java/datadog/trace/plugin/csi/impl/CallSiteSpecification.java
Outdated
Show resolved
Hide resolved
anderruiz
reviewed
Sep 7, 2022
buildSrc/src/main/java/datadog/trace/plugin/csi/impl/FreemarkerAdviceGenerator.java
Outdated
Show resolved
Hide resolved
anderruiz
reviewed
Sep 7, 2022
buildSrc/src/main/java/datadog/trace/plugin/csi/impl/FreemarkerAdviceGenerator.java
Outdated
Show resolved
Hide resolved
anderruiz
reviewed
Sep 7, 2022
buildSrc/src/main/java/datadog/trace/plugin/csi/impl/FreemarkerAdviceGenerator.java
Outdated
Show resolved
Hide resolved
anderruiz
reviewed
Sep 7, 2022
buildSrc/src/main/java/datadog/trace/plugin/csi/impl/FreemarkerAdviceGenerator.java
Outdated
Show resolved
Hide resolved
anderruiz
reviewed
Sep 7, 2022
buildSrc/src/main/java/datadog/trace/plugin/csi/impl/FreemarkerAdviceGenerator.java
Outdated
Show resolved
Hide resolved
anderruiz
reviewed
Sep 8, 2022
buildSrc/src/test/groovy/CallSiteInstrumentationPluginTest.groovy
Outdated
Show resolved
Hide resolved
anderruiz
approved these changes
Sep 8, 2022
smola
approved these changes
Sep 14, 2022
9503215 to
1cdf587
Compare
Member
Author
b662393 to
6dd5da1
Compare
094bb6c to
748af47
Compare
04f2040 to
7eba20f
Compare
bantonsson
approved these changes
Oct 7, 2022
Contributor
bantonsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another huge PR done 😅
Really nice with the example and benchmark.
Member
Author
Thank you very much for the review, I promise that this is the last PR behemoth 😄 |
7eba20f to
b32b1c1
Compare
This was referenced Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm iast
Application Security Management (IAST)
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR defines a new gradle plugin to auto generate call site instrumentation advices, the code is separated in two commits:
datadog.trace.agent.tooling.csi.CallSiteAdviceclasses. The next piece of code is an example of a class defining advices:Motivation
Instrumentations related to IAST often affect core parts of the JDK (String, StringBuilder...) where using callee instrumentation (by default in ByteBuddy) is not good enough for performance. Call site instrumentation focuses on the calls to the instrumented methods enabling the use of inclusion/exclusion lists to fine tune where to instrument.
Additional Notes
Real usage of this plugin is located at String builder taint tracking #3904
Performance remarks
Preliminary startup performance results from the benchmark with petclinic: