String builder taint tracking #3904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-alvarez-alvarez
added
the
tag: no release notes
manuel-alvarez-alvarez
changed the title
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
4 times, most recently
from
8ef9993 to
be1472a
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
6 times, most recently
from
13140d4 to
74191bd
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
from
74191bd to
5fd71b3
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
2 times, most recently
from
cda5a8a to
4c87cbc
Compare
jandro996
reviewed
Oct 11, 2022
...t/agent-iast/src/test/groovy/com/datadog/iast/IastModuleImplOnStringBuilderAppendTest.groovy
Outdated
Show resolved
Hide resolved
Member
|
Maybe we must discuss if we have to instrument this methods that are not available in this PR
|
Member
Author
Yep we should create new JIRAS for them. |
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
from
4c87cbc to
542efb2
Compare
jandro996
approved these changes
Oct 11, 2022
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
3 times, most recently
from
73668b4 to
96a496a
Compare
jandro996
reviewed
Oct 18, 2022
dd-java-agent/agent-iast/src/jmh/java/com/datadog/iast/propagation/StringConcatBenchmark.java
Outdated
Show resolved
Hide resolved
dd-java-agent/agent-iast/src/main/java/com/datadog/iast/IastModuleImpl.java
Show resolved
Hide resolved
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
2 times, most recently
from
42cede2 to
bae3cac
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
4 times, most recently
from
7e80c3e to
376bc40
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
from
376bc40 to
314c928
Compare
smola
reviewed
Nov 10, 2022
smola
approved these changes
Nov 10, 2022
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
from
314c928 to
24c275e
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/string-builder-taint-tracking
branch
from
24c275e to
b77d278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds all the instrumentation needed to perform taint tacking in the tracer for common string operations.
Motivation
IAST requires to track all modifications that happen to strings in the code, this PR uses CSI to instrument the most common string operations.
Additional Notes
Future PR will complete the support with other operations and classes